Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecto 3 Compatibility #83

Merged
merged 1 commit into from
Jan 11, 2019
Merged

Conversation

maennchen
Copy link

This PR provides Ecto 3.0 compatibility. Since I have trouble getting the application to work, I had no chance to try it out but rather just fixed all tests that were failing.

@coveralls
Copy link

coveralls commented Nov 23, 2018

Pull Request Test Coverage Report for Build 346

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.02%) to 94.118%

Files with Coverage Reduction New Missed Lines %
lib/rummage_ecto/hooks/paginate.ex 2 81.82%
Totals Coverage Status
Change from base Build 344: 0.02%
Covered Lines: 336
Relevant Lines: 357

💛 - Coveralls

@distortia
Copy link

Any updates on this or anything I can help with? I am looking to migrate to Ecto 3.

@g13ydson
Copy link

Any updates about? I want to use with phoenix 1.4, but I waiting for this update.

@thebugcatcher
Copy link
Contributor

Looks good! Thanks for the contribution @maennchen!

@thebugcatcher thebugcatcher merged commit b9f6c94 into annkissam:v2.0 Jan 11, 2019
@maennchen maennchen deleted the ecto3-compatibility branch January 11, 2019 15:57
@maennchen maennchen restored the ecto3-compatibility branch January 14, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants