Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Annotation deselect when selecting programmatically" fix in this plugin? #137

Closed
Neirokin opened this issue Aug 18, 2022 · 4 comments
Closed
Labels
bug Something isn't working

Comments

@Neirokin
Copy link

I have the same problem (annotorious/annotorious#207) with this plugin. Have you added a fix here?

@rsimon
Copy link
Member

rsimon commented Aug 27, 2022

Ok, weird. Although the consequence is the same, this issue is completely different internally. It looks like OpenSeadragon just stops firing events after programmatic selection (it's not even possible to navigate the image). I'll investigate.

@rsimon rsimon added the bug Something isn't working label Aug 27, 2022
@rsimon rsimon closed this as completed in 33058a4 Aug 27, 2022
@thanhhau097
Copy link

I still face this problem with the newest version on the main branch. After we call anno.selectAnnotation(annotationId), we can only interact with OSD when we hover the mouse over/click on the annotation. Can you please have a look again?

rsimon added a commit that referenced this issue Sep 3, 2022
@rsimon rsimon reopened this Sep 3, 2022
@rsimon
Copy link
Member

rsimon commented Sep 3, 2022

Yikes - looks like I had my testing set up incorrectly the last time. I think this should work now (after the commit above). But will need to check back more thoroughly later. I'm re-opening the issue.

@thanhhau097
Copy link

Thanks so much for a very quick fix. I tested it with my case and now it works well.

@rsimon rsimon closed this as completed Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants