schemachanger: add zone config interfaces/functions in builder

This patch adds the necessary interfaces/functions for
zone config verification and retrieval.

Informs: cockroachdb#117574
Release note: None

pkg/sql/descriptor.go

@@ -291,7 +291,11 @@ func (p *planner) checkRegionIsCurrentlyActive(
 ) error {
 	var liveRegions LiveClusterRegions
 	if !p.execCfg.Codec.ForSystemTenant() && isSystemDatabase {
-		systemRegions, err := p.regionsProvider().GetSystemRegions(ctx)
+		provider := p.regionsProvider()
+		if provider == nil {
+			return errors.AssertionFailedf("no regions provider available")
+		}
+		systemRegions, err := provider.GetSystemRegions(ctx)
 		if err != nil {
 			return err
 		}

pkg/sql/planner.go

@@ -666,6 +666,15 @@ func (p *planner) TemporarySchemaName() string {
 	return temporarySchemaName(p.ExtendedEvalContext().SessionID)
 }
 
+// GetRegions implements scbuildstmt.GetRegions.
+func (p *planner) GetRegions(ctx context.Context) (*serverpb.RegionsResponse, error) {
+	provider := p.regionsProvider()
+	if provider == nil {
+		return nil, errors.AssertionFailedf("no regions provider available")
+	}
+	return provider.GetRegions(ctx)
+}
+
 // DistSQLPlanner returns the DistSQLPlanner
 func (p *planner) DistSQLPlanner() *DistSQLPlanner {
 	return p.extendedEvalCtx.DistSQLPlanner

pkg/sql/schema_change_plan_node.go

@@ -114,6 +114,7 @@ func (p *planner) newSchemaChangeBuilderDependencies(statements []string) scbuil
 		NewReferenceProviderFactory(p),
 		p.EvalContext().DescIDGenerator,
 		p,
+		p.ExecCfg().NodesStatusServer,
 	)
 }
 

pkg/sql/schemachanger/scbuild/build.go

@@ -420,6 +420,8 @@ type buildCtx struct {
 	scbuildstmt.TreeAnnotator
 	scbuildstmt.SchemaFeatureChecker
 	TemporarySchemaProvider
+	NodesStatusInfo
+	RegionProvider
 }
 
 var _ scbuildstmt.BuildCtx = buildCtx{}

pkg/sql/schemachanger/scbuild/dependencies.go

@@ -76,7 +76,7 @@ type Dependencies interface {
 	DescriptorCommentGetter() CommentGetter
 
 	// ZoneConfigGetter returns a zone config reader.
-	ZoneConfigGetter() ZoneConfigGetter
+	ZoneConfigGetter() scdecomp.ZoneConfigGetter
 
 	// ClientNoticeSender returns a eval.ClientNoticeSender.
 	ClientNoticeSender() eval.ClientNoticeSender
@@ -217,9 +217,6 @@ type AstFormatter interface {
 	FormatAstAsRedactableString(statement tree.Statement, annotations *tree.Annotations) redact.RedactableString
 }
 
-// ZoneConfigGetter see scdecomp.ZoneConfigGetter.
-type ZoneConfigGetter scdecomp.ZoneConfigGetter
-
 // CommentGetter see scdecomp.CommentGetter.
 type CommentGetter scdecomp.CommentGetter
 
@@ -265,4 +262,6 @@ type (
 	FeatureChecker = scbuildstmt.SchemaFeatureChecker
 
 	TemporarySchemaProvider = scbuildstmt.TemporarySchemaProvider
+	NodesStatusInfo         = scbuildstmt.NodeStatusInfo
+	RegionProvider          = scbuildstmt.RegionProvider
 )

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/BUILD.bazel

@@ -41,6 +41,7 @@ go_library(
         "//pkg/geo/geoindex",
         "//pkg/keys",
         "//pkg/security/username",
+        "//pkg/server/serverpb",
         "//pkg/server/telemetry",
         "//pkg/settings",
         "//pkg/settings/cluster",

pkg/sql/schemachanger/scbuild/internal/scbuildstmt/dependencies.go

@@ -15,11 +15,13 @@ import (
 
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/security/username"
+	"github.com/cockroachdb/cockroach/pkg/server/serverpb"
 	"github.com/cockroachdb/cockroach/pkg/settings/cluster"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/catpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/descpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/privilege"
+	"github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scdecomp"
 	"github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scpb"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/catid"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/eval"
@@ -43,6 +45,8 @@ type BuildCtx interface {
 	TreeAnnotator
 	TreeContextBuilder
 	Telemetry
+	NodeStatusInfo
+	RegionProvider
 
 	// Add adds an absent element to the BuilderState, targeting PUBLIC.
 	Add(element scpb.Element)
@@ -60,6 +64,9 @@ type BuildCtx interface {
 
 	// Codec returns the codec for the current tenant.
 	Codec() keys.SQLCodec
+
+	// ZoneConfigGetter returns the zone config getter.
+	ZoneConfigGetter() scdecomp.ZoneConfigGetter
 }
 
 // ClusterAndSessionInfo provides general cluster and session info.
@@ -443,3 +450,20 @@ type TemporarySchemaProvider interface {
 	// session.
 	TemporarySchemaName() string
 }
+
+// NodeStatusInfo provides access to observe node descriptors.
+type NodeStatusInfo interface {
+
+	// NodesStatusServer gives access to the NodesStatus service and is only
+	// available when running as a system tenant.
+	NodesStatusServer() *serverpb.OptionalNodesStatusServer
+}
+
+// RegionProvider abstracts the lookup of regions. It is used to implement
+// crdb_internal.regions, which ultimately drives `SHOW REGIONS` and the
+// logic in the commands to manipulate multi-region features.
+type RegionProvider interface {
+	// GetRegions provides access to the set of regions available to the
+	// current tenant.
+	GetRegions(ctx context.Context) (*serverpb.RegionsResponse, error)
+}

pkg/sql/schemachanger/scdeps/BUILD.bazel

@@ -17,6 +17,7 @@ go_library(
         "//pkg/kv",
         "//pkg/roachpb",
         "//pkg/security/username",
+        "//pkg/server/serverpb",
         "//pkg/server/telemetry",
         "//pkg/settings/cluster",
         "//pkg/sql/catalog",
@@ -29,6 +30,7 @@ go_library(
         "//pkg/sql/isql",
         "//pkg/sql/rowenc",
         "//pkg/sql/schemachanger/scbuild",
+        "//pkg/sql/schemachanger/scdecomp",
         "//pkg/sql/schemachanger/scexec",
         "//pkg/sql/schemachanger/scexec/backfiller",
         "//pkg/sql/schemachanger/scexec/scmutationexec",

pkg/sql/schemachanger/scdeps/build_deps.go

@@ -16,6 +16,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/keys"
 	"github.com/cockroachdb/cockroach/pkg/kv"
 	"github.com/cockroachdb/cockroach/pkg/roachpb"
+	"github.com/cockroachdb/cockroach/pkg/server/serverpb"
 	"github.com/cockroachdb/cockroach/pkg/server/telemetry"
 	"github.com/cockroachdb/cockroach/pkg/settings/cluster"
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog"
@@ -26,6 +27,7 @@ import (
 	"github.com/cockroachdb/cockroach/pkg/sql/catalog/resolver"
 	"github.com/cockroachdb/cockroach/pkg/sql/rowenc"
 	"github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scbuild"
+	"github.com/cockroachdb/cockroach/pkg/sql/schemachanger/scdecomp"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/catconstants"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/eval"
 	"github.com/cockroachdb/cockroach/pkg/sql/sem/tree"
@@ -56,6 +58,7 @@ func NewBuilderDependencies(
 	referenceProviderFactory scbuild.ReferenceProviderFactory,
 	descIDGenerator eval.DescIDGenerator,
 	temporarySchemaProvider scbuild.TemporarySchemaProvider,
+	nodesStatusServer serverpb.OptionalNodesStatusServer,
 ) scbuild.Dependencies {
 	return &buildDeps{
 		clusterID:       clusterID,
@@ -76,6 +79,7 @@ func NewBuilderDependencies(
 		descIDGenerator:          descIDGenerator,
 		referenceProviderFactory: referenceProviderFactory,
 		temporarySchemaProvider:  temporarySchemaProvider,
+		nodesStatusServer:        nodesStatusServer,
 	}
 }
 
@@ -96,6 +100,7 @@ type buildDeps struct {
 	referenceProviderFactory scbuild.ReferenceProviderFactory
 	descIDGenerator          eval.DescIDGenerator
 	temporarySchemaProvider  scbuild.TemporarySchemaProvider
+	nodesStatusServer        serverpb.OptionalNodesStatusServer
 }
 
 var _ scbuild.CatalogReader = (*buildDeps)(nil)
@@ -360,6 +365,11 @@ func (d *buildDeps) ClusterSettings() *cluster.Settings {
 	return d.settings
 }
 
+// NodesStatusServer implements the scbuild.Dependencies interface.
+func (d *buildDeps) NodesStatusServer() serverpb.OptionalNodesStatusServer {
+	return d.nodesStatusServer
+}
+
 // Statements implements the scbuild.Dependencies interface.
 func (d *buildDeps) Statements() []string {
 	return d.statements
@@ -455,7 +465,7 @@ func (d *buildDeps) DescriptorCommentGetter() scbuild.CommentGetter {
 	return d.descsCollection
 }
 
-func (d *buildDeps) ZoneConfigGetter() scbuild.ZoneConfigGetter {
+func (d *buildDeps) ZoneConfigGetter() scdecomp.ZoneConfigGetter {
 	return &zoneConfigGetter{
 		txn:         d.txn,
 		descriptors: d.descsCollection,

pkg/sql/schemachanger/scdeps/sctestutils/sctestutils.go

@@ -102,6 +102,7 @@ func WithBuilderDependenciesFromTestServer(
 		refProviderFactory,
 		descidgen.NewGenerator(s.ClusterSettings(), s.Codec(), s.DB()),
 		planner,
+		execCfg.NodesStatusServer,
 	))
 }