Fix audio.tags nonetype bug #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anoadragon453
requested changes
Feb 6, 2022
There was a problem hiding this comment.
This appears to be a feature rather than a bug: https://github.com/quodlibet/mutagen/blob/30f373fa6d56e1afa17d48a0c6f3e111267fbd32/mutagen/id3/_file.py#L410. Many mutagen.FileType objects look to set tags to None, including ID3.
This appears to be more a need to mention this edge case in the documentation: quodlibet/mutagen#552
anoadragon453
approved these changes
Feb 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #73. During Busty's 3, a certain mp3 file caused busty to hang forever. The reason was because in the
get_cover_art()function, theaudiovariable tested True forisinstance(audio, ID3FileType)butaudio.tagswasNone. From what I can tell, this is a bug in mutagen itself, as the documentation seems to suggest that this field should always be of typeTags. This PR checks that attributes of MutagenFile are notNonebefore using them.