Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that a FileType's tags attribute may be None #552

Closed
wants to merge 2 commits into from

Conversation

anoadragon453
Copy link

The tags attribute of a FileType object can be None if the tags failed to be read. For example, in ID3FileType:

try:
self.tags = ID3(fileobj, **kwargs)
except ID3NoHeaderError:
self.tags = None

This PR mentions this in the documentation.

@lazka
Copy link
Member

lazka commented Apr 1, 2022

Hm, that's not totally right. ID3NoHeaderError just means there were no tags found. If it failed to read them it would fail completely.

@lazka
Copy link
Member

lazka commented Jul 16, 2022

There are probably way to make this more clear to users (type annotations and inline docs?), but this isn't it, so closing.

@lazka lazka closed this Jul 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants