Allow any version post 4.x to be used #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
misund
added a commit
to dbmedialab-archive/shiny
that referenced
this pull request
Apr 25, 2018
We indirectly depend on anodynos/upath via webpack. upath specifically states it does not support node > 9. Stable should be added back in as soon as our dependency graph has updated to address this – hopefully it will not be too long. See anodynos/upath#14 See anodynos/upath#15
4 tasks
misund
added a commit
to dbmedialab-archive/shiny
that referenced
this pull request
Apr 25, 2018
We indirectly depend on anodynos/upath via webpack. upath specifically states it does not support node > 9. Stable should be added back in as soon as our dependency graph has updated to address this – hopefully it will not be too long. See anodynos/upath#14 See anodynos/upath#15
ZauberNerd
approved these changes
Apr 25, 2018
robin-drexler
approved these changes
Apr 25, 2018
supertassu
approved these changes
Apr 25, 2018
ilessiivi
approved these changes
Apr 25, 2018
wopian
referenced
this pull request
in wopian/kitsu-season-trends
Apr 25, 2018
|
Maybe worth adding Node 10 and/or "stable" to the test matrix as well? |
|
Nice catch @mAAdhaTTah! I have added |
Closed
Closed
Closed
matthias-reis
approved these changes
Apr 26, 2018
4 tasks
schliflo
approved these changes
Apr 26, 2018
robertknight
added a commit
to robertknight/tex-linebreak
that referenced
this pull request
Apr 26, 2018
Use a forked upath until [1] is resolved following the method described at [2] [1] anodynos/upath#15 [2] https://stackoverflow.com/a/41082766/434243
robertknight
added a commit
to robertknight/tex-linebreak
that referenced
this pull request
Apr 26, 2018
Use a forked upath until [1] is resolved following the method described at [2] [1] anodynos/upath#15 [2] https://stackoverflow.com/a/41082766/434243
nickserv
approved these changes
Apr 26, 2018
gre
approved these changes
Apr 26, 2018
yocontra
approved these changes
Apr 26, 2018
|
cc @anodynos we need this to be merged asap. |
mririgoyen
approved these changes
Apr 27, 2018
BorisTB
approved these changes
Apr 27, 2018
|
Please stop approving this PR, it triggers unnecessary email notification to all subscribed users and adds nothing. (and users read this notification in hope that this PR is finally merged) |
|
Hello everyone, sorry for the wait - I will merge this soon and publish! |
grrowl
added a commit
to grrowl/recompose
that referenced
this pull request
May 10, 2018
Fixes issue with webpack 2.7.0 -> upath 1.0.5 dependency, which incorrectly specifies compatibility with node <= 9 Issue described here: anodynos/upath#15
grrowl
added a commit
to grrowl/recompose
that referenced
this pull request
May 10, 2018
Fixes issue with webpack 2.7.0 -> upath 1.0.5 dependency, which incorrectly specifies compatibility with node <= 9 Issue described here: anodynos/upath#15
istarkov
pushed a commit
to acdlite/recompose
that referenced
this pull request
May 10, 2018
Fixes issue with webpack 2.7.0 -> upath 1.0.5 dependency, which incorrectly specifies compatibility with node <= 9 Issue described here: anodynos/upath#15
alangpierce
added a commit
to alangpierce/babel
that referenced
this pull request
Jul 7, 2018
upath 1.0.4 doesn't support node 10, and this was fixed in later versions ( anodynos/upath#15 ), but Babel's yarn.lock pinned the version to 1.0.4. Normal Babel builds use `yarn --ignore-engines` to work around this, but I have a script that clones and builds a number of repositories and assumes that all of them can run `yarn` after cloning without error. Upgrading upath fixes plain `yarn` on node 10 so I don't need to add a special case when cloning/building Babel. As described in yarnpkg/yarn#4986 (comment) , I did this by deleting the yarn.lock entry and re-running `yarn`. (It's a little tricky to upgrade since it's an indirect dependency.) I believe this means that it should be safe to remove `--ignore-engines` from travis.yml and Makefile, but I left those alone since arguably `--ignore-engines` is nice in that it protects against future similar issues.
alangpierce
added a commit
to alangpierce/babel
that referenced
this pull request
Jul 7, 2018
upath 1.0.4 doesn't support node 10, and this was fixed in later versions ( anodynos/upath#15 ), but Babel's yarn.lock pinned the version to 1.0.4. Normal Babel builds use `yarn --ignore-engines` to work around this, but I have a script that clones and builds a number of repositories (including Babel) and assumes that all of them can run `yarn` after cloning without error. Upgrading upath fixes plain `yarn` on node 10 so I don't need to add a special case when cloning/building Babel. As described in yarnpkg/yarn#4986 (comment) , I did this by deleting the yarn.lock entry and re-running `yarn`. (It's a little tricky to upgrade since it's an indirect dependency.) I believe this means that it should be safe to remove `--ignore-engines` from travis.yml and Makefile, but I left those alone since arguably `--ignore-engines` is nice in that it protects against future similar issues.
hzoo
pushed a commit
to babel/babel
that referenced
this pull request
Jul 7, 2018
upath 1.0.4 doesn't support node 10, and this was fixed in later versions ( anodynos/upath#15 )
chocolateboy
added a commit
to chocolateboy/babel-plugin-source-map-support
that referenced
this pull request
Aug 23, 2018
error:
error upath@1.0.2: The engine "node" is incompatible with this module.
Expected version ">=4 <=9".
upath is required via:
$ yarn why upath
gulp#glob-watcher#chokidar#upath
which had an "engines" entry in its package.json which prevented it
working on node v10
1) the issue has been fixed in upath:
anodynos/upath#15
2) chokidar has been updated to point to the updated upath:
paulmillr/chokidar#717
3) glob-watcher has not been updated to point to the updated chokidar:
gulpjs/glob-watcher#37
This was referenced Nov 12, 2018
jdunn9516
added a commit
to jdunn9516/re-compose
that referenced
this pull request
Jul 24, 2024
Fixes issue with webpack 2.7.0 -> upath 1.0.5 dependency, which incorrectly specifies compatibility with node <= 9 Issue described here: anodynos/upath#15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Node.js 10 released today, and with
@vue/climaking use of this library, it is not possible to set the Vue application as 10 is not in the range=>4 <=9. This PR tweaks it so any version above Node.js 4 is supported.Probably fixes #14.
Edit:
After doing some research, it seems that the root of the issue is in
webpack(which vue and many other frameworks use, and also has millions of downloads a week) indirectly depends on this package, did some research and:So anyone using yarn in Node.js 10 and any of webpack's +8.6k dependents would encounter this issue.