Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node@9 9.11.1 #27101

Closed
wants to merge 1 commit into from
Closed

node@9 9.11.1 #27101

wants to merge 1 commit into from

Conversation

jasonseminara
Copy link

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@ryenus
Copy link
Contributor

ryenus commented Apr 26, 2018

Too bad this wasn't part of the node 10 formulae update

@ilovezfs
Copy link
Contributor

Thanks for the suggestion @jasonseminara. However, we only add node@* versioned formulae for the LTS releases, which is not the case here.

@ilovezfs ilovezfs closed this Apr 26, 2018
@ryenus
Copy link
Contributor

ryenus commented Apr 26, 2018

Here is a reason for this:

So anyone using yarn in Node.js 10 and any of webpack's +8.6k dependents would encounter this issue.

@ilovezfs
Copy link
Contributor

@ryenus I don't follow. Use node@8, no?

@ryenus
Copy link
Contributor

ryenus commented Apr 26, 2018

maybe yes, but if one was previously using node v9, having an option to reinstall the same version, is probably the best.

@chrmoritz
Copy link
Contributor

chrmoritz commented Apr 26, 2018

Assuming you didn't removed node 9.11.1 from the Cellar yet, you could just go back with brew switch node 9.11.1.
Node 9 is currently in maitance only and will only receive an update again, if there will be a security update released until End of June, when it will finally become EOL.
That being said, a versioned formula does make more sense if the release line is still actively worked one, which is not the case for node@9.

And regarding the issue with incorrect engines ranges in upath: You could just set ignore-engines to true in your yarn config to stop yarn from erroring out on unmatched engine ranges (in npm it would be only a warning btw).

@anodynos
Copy link

Hello everyone - I merged anodynos/upath#15 & published it - thanks & sorry for the delay! You remove the ignore-engines workaround.

@ilovezfs
Copy link
Contributor

Thanks @anodynos!

This was referenced May 2, 2018
@lock lock bot added the outdated PR was locked due to age label May 30, 2018
@lock lock bot locked as resolved and limited conversation to collaborators May 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants