Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify Eth Headers #1010

Draft
wants to merge 28 commits into
base: main
Choose a base branch
from
Draft

Verify Eth Headers #1010

wants to merge 28 commits into from

Conversation

batconjurer
Copy link
Member

@batconjurer batconjurer commented Mar 29, 2022

This PR builds on #995

Adds an ethash algorithm (mostly cribbed from here) to verify ethereum headers. Because the hash must use a pseudorandom cache that is

  1. expensive to compute
  2. but valid for a 30000 blocks
    we add a background process to precompute this cache, keeping verification times fast.

This required refactoring the Anoma types for interacting with Ethereum types.

N.B. This requires the latest commit of Tendermint ABCI++ branch

batconjurer and others added 23 commits February 28, 2022 11:27
…oring and feature flags for wasm compatibility
@batconjurer batconjurer added m1 ethereum-bridge Relates to the M1 Ethereum bridge namada For features / fixes related to the Namada release enhancement New feature or request labels Mar 29, 2022
@@ -127,7 +127,10 @@ audit:
test: test-unit test-e2e test-wasm

test-e2e:
RUST_BACKTRACE=1 $(cargo) test e2e -- --test-threads=1
RUST_BACKTRACE=1 $(cargo) test e2e \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change needed? It seems to work with the defaults

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that at first to use the mock eth node, but I forgot the we compile as part of the e2e test. So it is not needed.

Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes LGTM, we need to resolve the CI before merging (and changelog pls)

@batconjurer
Copy link
Member Author

pls update wasm

@tzemanovic
Copy link
Member

the design of the bridge has been revised and so this PR won't be used (remains open for salvaging common parts)

@tzemanovic tzemanovic marked this pull request as draft June 30, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ethereum-bridge Relates to the M1 Ethereum bridge m1 namada For features / fixes related to the Namada release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants