Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly-incorrect type error where Geb expects a product type #58

Closed
rokopt opened this issue Feb 13, 2023 · 5 comments
Closed

Possibly-incorrect type error where Geb expects a product type #58

rokopt opened this issue Feb 13, 2023 · 5 comments
Assignees

Comments

@rokopt
Copy link
Member

rokopt commented Feb 13, 2023

See this comment to #47. I'm not immediately sure whether this is supposed to produce a type error or not, but I will investigate it and fix it if it's supposed to typecheck. I'm not sure whether there's any relationship with #57 not being implemented yet or not.

@rokopt
Copy link
Member Author

rokopt commented Feb 17, 2023

I think I've made a test case out of the term that originally produced this error:

f1baf14

It doesn't run into the "not a product type" problem documented in the comment , though. I'm not specifically aware of anything having changed since that might have fixed it, but I might be missing something. Does the problem still occur with the Juvix-generated code?

@rokopt
Copy link
Member Author

rokopt commented Feb 17, 2023

...Apparently all I needed to do was post that, and suddenly my test has started reproducing the "not a product type" error, without my making further changes. Some Lisp test infrastructure caching bug or something? I have no idea.

rokopt added a commit that referenced this issue Feb 17, 2023
@rokopt
Copy link
Member Author

rokopt commented Feb 17, 2023

This might be the bug:

6f28b5b

@rokopt
Copy link
Member Author

rokopt commented Feb 17, 2023

#70 includes what I think might be a fix for this.

@rokopt
Copy link
Member Author

rokopt commented Feb 22, 2023

I believe this has been fixed by c356c6c (borrowed from the fix in #70).

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant