Don't fold lets with fail, trace or >-> in the body
#2973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| where | ||
| isDebugOp :: Node -> Bool | ||
| isDebugOp = \case | ||
| NBlt (BuiltinApp {..}) -> _builtinAppOp `elem` [OpTrace, OpFail, OpSeq] |
There was a problem hiding this comment.
Suggested change
| NBlt (BuiltinApp {..}) -> _builtinAppOp `elem` [OpTrace, OpFail, OpSeq] | |
| NBlt BuiltinApp {..} -> _builtinAppOp `elem` [OpTrace, OpFail, OpSeq] |
janmasrovira
approved these changes
Aug 27, 2024
janmasrovira
pushed a commit
that referenced
this pull request
Sep 14, 2024
After * #2973 let-folding stopped being linear in the size of the input program. All transformations should be linear whenever possible. This PR makes let-folding linear again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid optimizing e.g.
into
which is annoying when debugging.