Enforcing fee payment on transactions #3075
Labels
Milestone
Comments
|
Hmm - could we perhaps just simulate running the transactions in order when preparing the proposal, and drop any for which there is no longer enough balance? |
tzemanovic
added a commit
that referenced
this issue
May 24, 2024
* origin/grarco/force-fee-payment: Fmt Changelog #3075 Fixes typo Misc adjustments to v36 Adds integration test for enforced fees Removes useless operations on wrapper transactions Removes useless check on tx type for reprot management Fixes unit tests Pass tx by reference in `apply_wrapper_tx` Removes unused wasm caches for wrapper execution Refactors the arguments of `dispatch_tx` for every tx type Cache wrapper transaction to avoid second deserialization Reorganizes arguments for tx execution Refactors tx execution of `finalize_block` into separate functions Fixes fee payment
tzemanovic
added a commit
that referenced
this issue
May 24, 2024
* origin/grarco/force-fee-payment: Fmt Changelog #3075 Fixes typo Misc adjustments to v36 Adds integration test for enforced fees Removes useless operations on wrapper transactions Removes useless check on tx type for reprot management Fixes unit tests Pass tx by reference in `apply_wrapper_tx` Removes unused wasm caches for wrapper execution Refactors the arguments of `dispatch_tx` for every tx type Cache wrapper transaction to avoid second deserialization Reorganizes arguments for tx execution Refactors tx execution of `finalize_block` into separate functions Fixes fee payment
brentstone
added a commit
that referenced
this issue
May 30, 2024
* origin/grarco/force-fee-payment: Fmt Changelog #3075 Fixes typo Misc adjustments to v36 Adds integration test for enforced fees Removes useless operations on wrapper transactions Removes useless check on tx type for reprot management Fixes unit tests Pass tx by reference in `apply_wrapper_tx` Removes unused wasm caches for wrapper execution Refactors the arguments of `dispatch_tx` for every tx type Cache wrapper transaction to avoid second deserialization Reorganizes arguments for tx execution Refactors tx execution of `finalize_block` into separate functions Fixes fee payment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After merging #2627 the transactions are now executed in order without the need to split the wrappers from the wasm transactions which poses an issue when it comes to fee payment that wasn't there in the previous execution model. In
process_proposalwe verify that the signer of a tx has enough balance to pay the fees for that tx: unfortunately though, with the new logic, the fee payment executed by the wrapper txs are now interspersed with the execution of the wasm codes. These could be transactions modifying the balance of the fee payers of the next transactions, meaning that the result of the check performed inprocess_proposalisn't valid anymore.A possible solution could be to somewhat mimic the previous execution model by first collecting all the fees due by the transactions in the block and only then execute the wasm codes. This though would require some major changes (once more) in the execution model.
The text was updated successfully, but these errors were encountered: