Bat/feat/remove tx queue #2627

batconjurer · 2024-02-15T16:35:02Z

Describe your changes

Instead of having every user tx be executed across two blocks, the first executing a wrapper and the second executing the main payload, this change makes it so that the entire tx is executed in a single block (or rejected).

Closes #2656

NOTE: This requires changes to hermes and so the ci will not pass until that is done.

Indicate on which release or other PRs this topic is based on

Checklist before merging to `draft`

I have added a changelog
Git history is in acceptable state

codecov-commenter · 2024-02-16T12:26:57Z

Codecov Report

Attention: Patch coverage is 68.43034% with 179 lines in your changes are missing coverage. Please review.

Project coverage is 53.59%. Comparing base (2ba001d) to head (e138cfb).
Report is 18 commits behind head on main.

Files	Patch %	Lines
crates/sdk/src/masp.rs	0.00%	95 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs	86.86%	18 Missing ⚠️
crates/apps/src/lib/bench_utils.rs	0.00%	16 Missing ⚠️
crates/sdk/src/tx.rs	0.00%	14 Missing ⚠️
...ates/apps/src/lib/node/ledger/shell/block_alloc.rs	89.47%	12 Missing ⚠️
crates/apps/src/lib/client/rpc.rs	0.00%	8 Missing ⚠️
.../apps/src/lib/node/ledger/shell/vote_extensions.rs	66.66%	6 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs	0.00%	3 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs	0.00%	1 Missing ⚠️
...apps/src/lib/node/ledger/shell/prepare_proposal.rs	97.82%	1 Missing ⚠️
... and 5 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2627      +/-   ##
==========================================
- Coverage   53.88%   53.59%   -0.29%     
==========================================
  Files         308      307       -1     
  Lines      100154    99262     -892     
==========================================
- Hits        53966    53201     -765     
+ Misses      46188    46061     -127

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/apps/src/lib/node/ledger/shell/block_alloc/states.rs

crates/apps/Cargo.toml

crates/apps/src/lib/node/ledger/shell/block_alloc.rs

crates/apps/src/lib/node/ledger/shell/testing/node.rs

crates/core/src/types/storage.rs

crates/namada/src/ledger/protocol/mod.rs

crates/tx/src/data/wrapper.rs

crates/apps/src/lib/node/ledger/shell/process_proposal.rs

wasm_for_tests/wasm_source/src/lib.rs

crates/namada/src/ledger/native_vp/masp.rs

sug0

still that one change in the allocator during PrepareProposal

grarco · 2024-02-23T13:35:11Z

Looks good to me but there's a failing integration test, is this expected?

batconjurer · 2024-02-23T14:11:53Z

Looks good to me but there's a failing integration test, is this expected?

No it is not. I'll need to look into that.

sug0

lgtm

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

* origin/bat/feat/remove-tx-queue: [fix]: Integration tests Rebased. Might require more fixes but unit tests are passing addressing review comments Addressing review comments Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/tx/src/data/wrapper.rs [fix]: Fix benchmarks Small fixes added changelog Fixing e2e tests fixed integration tests [fix]: unit test now passing First compiling version

* origin/bat/feat/remove-tx-queue: [fix]: Integration tests Rebased. Might require more fixes but unit tests are passing addressing review comments Addressing review comments Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs Update crates/tx/src/data/wrapper.rs [fix]: Fix benchmarks Small fixes added changelog Fixing e2e tests fixed integration tests [fix]: unit test now passing First compiling version # Conflicts: # crates/apps/src/lib/node/ledger/storage/rocksdb.rs # crates/storage/src/mockdb.rs # crates/storage/src/tx_queue.rs

batconjurer marked this pull request as draft February 15, 2024 16:35

batconjurer force-pushed the bat/feat/remove-tx-queue branch from b0ba052 to a3e5fb8 Compare February 16, 2024 11:54

batconjurer marked this pull request as ready for review February 16, 2024 11:54

sug0 added the breaking-change label Feb 19, 2024

batconjurer requested review from tzemanovic, grarco and sug0 February 19, 2024 14:38

batconjurer force-pushed the bat/feat/remove-tx-queue branch from 64af0de to 369b18f Compare February 19, 2024 14:53

grarco reviewed Feb 20, 2024

View reviewed changes

crates/apps/src/lib/node/ledger/shell/block_alloc/states.rs Outdated Show resolved Hide resolved

sug0 requested changes Feb 20, 2024

View reviewed changes

grarco reviewed Feb 20, 2024

View reviewed changes

crates/apps/src/lib/node/ledger/shell/process_proposal.rs Show resolved Hide resolved

grarco reviewed Feb 20, 2024

View reviewed changes

wasm_for_tests/wasm_source/src/lib.rs Show resolved Hide resolved

grarco reviewed Feb 20, 2024

View reviewed changes

crates/namada/src/ledger/native_vp/masp.rs Outdated Show resolved Hide resolved

batconjurer requested review from sug0 and grarco February 20, 2024 13:15

sug0 requested changes Feb 20, 2024

View reviewed changes

batconjurer requested a review from sug0 February 20, 2024 17:06

sug0 previously approved these changes Feb 21, 2024

View reviewed changes

tzemanovic previously approved these changes Feb 23, 2024

View reviewed changes

grarco mentioned this pull request Feb 28, 2024

Allowlists checks #2770

Closed

batconjurer dismissed stale reviews from tzemanovic and sug0 via c049ff5 March 2, 2024 16:30

batconjurer force-pushed the bat/feat/remove-tx-queue branch from ff85f53 to c049ff5 Compare March 2, 2024 16:30

batconjurer requested review from sug0 and tzemanovic March 3, 2024 12:06

sug0 previously approved these changes Mar 4, 2024

View reviewed changes

grarco mentioned this pull request Mar 5, 2024

Fix allowlist checks #2819

Merged

2 tasks

batconjurer and others added 15 commits March 8, 2024 11:52

fixed integration tests

5738288

Fixing e2e tests

3f06283

added changelog

32157be

Small fixes

816db39

[fix]: Fix benchmarks

93888b9

Update crates/tx/src/data/wrapper.rs

bf8d573

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs

a106856

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs

b373402

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs

e3481c8

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs

a8abe56

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Update crates/apps/src/lib/node/ledger/shell/block_alloc.rs

569277b

Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>

Addressing review comments

2a3bf58

addressing review comments

57a599c

Rebased. Might require more fixes but unit tests are passing

4770db6

[fix]: Integration tests

e138cfb

batconjurer dismissed sug0’s stale review via e138cfb March 8, 2024 10:52

batconjurer force-pushed the bat/feat/remove-tx-queue branch from ca9dc2f to e138cfb Compare March 8, 2024 10:52

Fraccaman mentioned this pull request Mar 8, 2024

Transaction gas as part of consensus #2853

Closed

2 tasks

tzemanovic added a commit that referenced this pull request Mar 18, 2024

fixup! Merge branch 'bat/feat/remove-tx-queue' (#2627)

c735ac5

tzemanovic mentioned this pull request Mar 18, 2024

Draft [breaking, mainnet] - released as 0.33.0 #2912

Closed

tzemanovic added the merged to draft label Mar 18, 2024

tzemanovic added a commit that referenced this pull request Mar 19, 2024

fixup! Merge branch 'bat/feat/remove-tx-queue' (#2627)

2db3acd

grarco mentioned this pull request Mar 19, 2024

Refactor replay protection #2922

Closed

Fraccaman mentioned this pull request Mar 20, 2024

Commit only merkle tree #2926

Merged

2 tasks

tzemanovic merged commit a7a3233 into main Apr 12, 2024
12 of 17 checks passed

tzemanovic deleted the bat/feat/remove-tx-queue branch April 12, 2024 10:22

grarco mentioned this pull request Apr 12, 2024

Enforcing fee payment on transactions #3075

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bat/feat/remove tx queue #2627

Bat/feat/remove tx queue #2627

batconjurer commented Feb 15, 2024 •

edited

codecov-commenter commented Feb 16, 2024 •

edited by codecov bot

sug0 left a comment

grarco commented Feb 23, 2024

batconjurer commented Feb 23, 2024

sug0 left a comment

Bat/feat/remove tx queue #2627

Bat/feat/remove tx queue #2627

Conversation

batconjurer commented Feb 15, 2024 • edited

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

codecov-commenter commented Feb 16, 2024 • edited by codecov bot

Codecov Report

sug0 left a comment

Choose a reason for hiding this comment

grarco commented Feb 23, 2024

batconjurer commented Feb 23, 2024

sug0 left a comment

Choose a reason for hiding this comment

batconjurer commented Feb 15, 2024 •

edited

Checklist before merging to `draft`

codecov-commenter commented Feb 16, 2024 •

edited by codecov bot