Governance custom proposals #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls update wasm |
grarco
force-pushed
the
fraccaman+grarco/governance-custom-proposals
branch
from
8a82a96
to
66a38ee
Compare
|
pls update wasm |
|
pls update wasm |
grarco
commented
Jan 31, 2023
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
grarco
force-pushed
the
fraccaman+grarco/governance-custom-proposals
branch
from
be60cac
to
bba2f0c
Compare
|
pls update wasm |
grarco
force-pushed
the
fraccaman+grarco/governance-custom-proposals
branch
from
06ef8b2
to
b4f3801
Compare
tzemanovic
reviewed
Feb 15, 2023
tzemanovic
reviewed
Feb 15, 2023
tzemanovic
reviewed
Feb 15, 2023
grarco
force-pushed
the
fraccaman+grarco/governance-custom-proposals
branch
from
d32c4e4
to
fabbd25
Compare
grarco
force-pushed
the
fraccaman+grarco/governance-custom-proposals
branch
from
fabbd25
to
b5c3c5b
Compare
tzemanovic
approved these changes
Apr 6, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 6, 2023
* fraccaman+grarco/governance-custom-proposals: changelog: add #1056 Refactors proposal execution Updates governance user guide [ci] wasm checksums update Fmt Removes unwrap from `compute_tally` Replaces `TallyResult::Failed` with `Error` Continues governance tally if wrong vote type Misc fixes Fixes vote memo in governance docs Clippy + fmt Removes comment Fixes nam value in governance eth test Fixes length of hex message in e2e tests Generates keypair for eth proposal e2e test Fixes typos in e2e tests Fixes pgf e2e test and governance vp Adds e2e test for eth proposal Refactors pgf council vote to HashSet Refactors custom proposal vote in client Updates cli proposal vote help Manages eth proposals in `finalize_block` Updates tally with eth proposals Updates governance vp for eth votes Adds ETH bridge cutom proposal Updates eth bridge vote in gov specs Clippy + fmt Fixes pgf e2e error Refunds for pgf proposal Finalizes pgf e2e test Improves governance VP vote check Improves pgf e2e test Fixes `ProposalType` serialization Clippy + fmt Adds pgf e2e test to github workflow Pgf proposal e2e test Fixes governance VP Improves governance vote command help Refactors cli governance vote. Improves custom proposal vote validation Clippy + fmt Refactors governance `Votes` Refactors `compute_tally` and removes duplicate Updates tally result Fixes governance specs Updates proposal tally for proposal types Updates governance specs with regard to PGF Updates init proposal tx and governance VP Renames `proposal_type` Adds `ProposalType` and `VoteType`
Closed
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #467
Implements custom governance proposals and votes.
It does not implement the logic to apply in
finalize_blockin case of a successful proposal (given the absence of the required elements): at the moment, we only perform refunding.ProposalTypeVoteType