Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ledger: default folder in home directory #1138

Merged
merged 5 commits into from
May 12, 2023
Merged

ledger: default folder in home directory #1138

merged 5 commits into from
May 12, 2023

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Feb 9, 2023 •
edited by tzemanovic
Loading

closes #53

@Fraccaman Fraccaman marked this pull request as ready for review February 9, 2023 11:45
tzemanovic
tzemanovic reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's couple references to ".namada" if you could pls also update the user guide docs and one in apps/src/lib/cli.rs BASE_DIR.def()

tzemanovic
tzemanovic reviewed Feb 15, 2023
View reviewed changes
apps/src/lib/cli.rs Outdated Show resolved Hide resolved
tzemanovic
tzemanovic reviewed Apr 11, 2023
View reviewed changes
apps/src/lib/cli.rs Outdated Show resolved Hide resolved
tzemanovic added a commit that referenced this pull request Apr 28, 2023
@tzemanovic
Merge branch 'fraccaman/base-directory' (#1138)
6ea72cf 
* fraccaman/base-directory:
  added changelog
  fix: review comments
  fix: doc strings
  fix: use data_dir
  ledger: default folder in home directory
@tzemanovic tzemanovic mentioned this pull request Apr 28, 2023
Closed
juped added a commit that referenced this pull request May 12, 2023
@juped
Merge remote-tracking branch 'namada/fraccaman/base-directory' (#1138)…
1982cbd 
… into main

* namada/fraccaman/base-directory:
  added changelog
  fix: review comments
  fix: doc strings
  fix: use data_dir
  ledger: default folder in home directory
@juped juped merged commit 5d187f0 into main May 12, 2023
@juped juped deleted the fraccaman/base-directory branch May 12, 2023 00:57
@juped juped mentioned this pull request May 13, 2023
Merged
juped added a commit that referenced this pull request May 15, 2023
@juped
changelog: correct #1138
462186b
juped added a commit that referenced this pull request May 15, 2023
@juped
Merge branch 'main' into ray/sdk-wip
e281f70 
* main:
  changelog: correct #1138
  Namada 0.15.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

consider using directories crate for base-dir and wasm-dir
3 participants
@Fraccaman @tzemanovic @juped