Fix Bridge pool recommendations #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
ca9b0d4
to
88dcf90
Compare
batconjurer
requested changes
Aug 15, 2023
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
628dc99
to
9a29d88
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
9a29d88
to
ff93833
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
ff93833
to
d8ddf6e
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
d8ddf6e
to
83bafe9
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
83bafe9
to
8079c9a
Compare
|
@batconjurer there's currently a gotcha in the recommendations algorithm, I think. the the current signed pool may be behind the most up to date Bridge pool, because of the vote extension tx lag. so, I believe the algorithm may recommend a transfer that has already been relayed, that still shows up in the signed pool. a simple solution may be to return with an error if the signed Bridge pool nonce does not match the up to date Bridge pool nonce in storage. this way we never recommend transfers that have already been relayed and acted upon |
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
8079c9a
to
1750a8e
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
1750a8e
to
b4b73e2
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
b4b73e2
to
1274ecb
Compare
sug0
force-pushed
the
tiago/bridge-pool-fees
branch
from
7c404af
to
968f1a6
Compare
sug0
force-pushed
the
tiago/fix-bp-recommendations
branch
from
ead7d26
to
c4e4819
Compare
Closed
2 tasks
sug0
added a commit
that referenced
this pull request
Aug 30, 2023
batconjurer
approved these changes
Aug 31, 2023
| let query_validators = query_validators!(); | ||
| let epoch_0_validators = query_validators(0); | ||
| let epoch_1_validators = query_validators(1); | ||
| _ = query_validators; |
There was a problem hiding this comment.
what is the purpose of this?
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-bp-recommendations: Add changelog for #1811 Ignore invalid conversion rates Add test_conversion_table_profit_margin() unit test Proper Debug impl for I256 values Return recommendation data in `generate_recommendations` Test the height of the BP proof stored in the db Check BP root's height when vote extension was signed Store height when BP root was signed Fail recommending BP batch of txs if nonce is out of date Prohibit generating BP proofs when the signed root is outdated More conversion table unit tests Abstract `generate_eligible` unit tests with a helper fn Add test_generate_eligible_happy_path() unit test Avoid overflowing when calculating earned gwei amount Improve conversion rate query Factor out `generate_eligible()` Fix Bridge pool proof warning voting power Rename `generate` to `generate_recommendations` Refactor recommendations to use EligibleRecommendation Add context to CLI Bridge pool cmds Fix Bridge pool `construct_proof` Convert gwei to tokens in Bridge pool conversion table Bridge pool conversion rates table Retrieve the inner raw string on wrapped context values
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-bp-recommendations: Add changelog for #1811 Ignore invalid conversion rates Add test_conversion_table_profit_margin() unit test Proper Debug impl for I256 values Return recommendation data in `generate_recommendations` Test the height of the BP proof stored in the db Check BP root's height when vote extension was signed Store height when BP root was signed Fail recommending BP batch of txs if nonce is out of date Prohibit generating BP proofs when the signed root is outdated More conversion table unit tests Abstract `generate_eligible` unit tests with a helper fn Add test_generate_eligible_happy_path() unit test Avoid overflowing when calculating earned gwei amount Improve conversion rate query Factor out `generate_eligible()` Fix Bridge pool proof warning voting power Rename `generate` to `generate_recommendations` Refactor recommendations to use EligibleRecommendation Add context to CLI Bridge pool cmds Fix Bridge pool `construct_proof` Convert gwei to tokens in Bridge pool conversion table Bridge pool conversion rates table Retrieve the inner raw string on wrapped context values
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/fix-bp-recommendations: Add changelog for #1811 Ignore invalid conversion rates Add test_conversion_table_profit_margin() unit test Proper Debug impl for I256 values Return recommendation data in `generate_recommendations` Test the height of the BP proof stored in the db Check BP root's height when vote extension was signed Store height when BP root was signed Fail recommending BP batch of txs if nonce is out of date Prohibit generating BP proofs when the signed root is outdated More conversion table unit tests Abstract `generate_eligible` unit tests with a helper fn Add test_generate_eligible_happy_path() unit test Avoid overflowing when calculating earned gwei amount Improve conversion rate query Factor out `generate_eligible()` Fix Bridge pool proof warning voting power Rename `generate` to `generate_recommendations` Refactor recommendations to use EligibleRecommendation Add context to CLI Bridge pool cmds Fix Bridge pool `construct_proof` Convert gwei to tokens in Bridge pool conversion table Bridge pool conversion rates table Retrieve the inner raw string on wrapped context values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1799
Indicate on which release or other PRs this topic is based on
Based on #1795
Checklist before merging to
draft