Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bridge pool recommendations #1811

Merged
merged 89 commits into from
Sep 6, 2023
Merged

Fix Bridge pool recommendations #1811

merged 89 commits into from
Sep 6, 2023

Commits on Aug 28, 2023

  1. Add Eth whitelist storage keys

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9ec1833 View commit details
    Browse the repository at this point in the history

  2. Add Eth whitelist key tests

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ed2afb2 View commit details
    Browse the repository at this point in the history

  3. Add non-usable tokens for Ethereum bridge protocol bookkeeping

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6ca25fd View commit details
    Browse the repository at this point in the history

  4. Add a VP for NUT transfers

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5208f3d View commit details
    Browse the repository at this point in the history

  5. Test NUT VP

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9c14b65 View commit details
    Browse the repository at this point in the history

  6. Trigger the NUT native VP

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4901296 View commit details
    Browse the repository at this point in the history

  7. Update ethbridge-rs to v0.19.0

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9b6df79 View commit details
    Browse the repository at this point in the history

  8. Add transfer to Ethereum kinds (ERC20 or NUT)

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b932890 View commit details
    Browse the repository at this point in the history

  9. Mint NUTs upon receiving non-whitelisted assets or exceeding token caps

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8297842 View commit details
    Browse the repository at this point in the history

  10. Add helper fn to whitelist tokens in tests

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    82320aa View commit details
    Browse the repository at this point in the history

  11. Fix unit tests requiring token whitelist checks

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1a70c4f View commit details
    Browse the repository at this point in the history

  12. Fix refunding and burning of NUTs

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    339e18a View commit details
    Browse the repository at this point in the history

  13. Rework DAI minting unit tests to account for NUTs

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d115bb0 View commit details
    Browse the repository at this point in the history

  14. Test burning NUTs

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d26e983 View commit details
    Browse the repository at this point in the history

  15. Check NUT escrow in Bridge pool VP

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8de897d View commit details
    Browse the repository at this point in the history

  16. Test NUTs in the Bridge pool

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a839866 View commit details
    Browse the repository at this point in the history

  17. Add NUT cmdline flag for Bridge pool transfers

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    180c986 View commit details
    Browse the repository at this point in the history

  18. Update ethbridge-rs to v0.20.0

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7732e24 View commit details
    Browse the repository at this point in the history

  19. Remove whitelist Ethereum events from the ledger

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    92bb87f View commit details
    Browse the repository at this point in the history

  20. Add whitelisted ERC20 tokens to the genesis file

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a1213c7 View commit details
    Browse the repository at this point in the history

  21. Update ethbridge-rs to v0.21.0

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4777038 View commit details
    Browse the repository at this point in the history

  22. Move ethbridge-rs deps to the workspace

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cde9503 View commit details
    Browse the repository at this point in the history

  23. Add changelog entry for the Ethereum token whitelist 

    Closes #1290
    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    20044d0 View commit details
    Browse the repository at this point in the history

  24. Add helper methods to EthAssetMint

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2ae23fb View commit details
    Browse the repository at this point in the history

  25. Use EthAssetMint helper methods

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f1be3f9 View commit details
    Browse the repository at this point in the history

  26. Refactor redeem_native_token to use update::amount

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    6ef086f View commit details
    Browse the repository at this point in the history

  27. Vet Ethereum bridge config of the native token

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    f1bd957 View commit details
    Browse the repository at this point in the history

  28. Harden Bridge pool VP against wNAM NUT transfers

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    69037fb View commit details
    Browse the repository at this point in the history

  29. Update wNAM supplies when acting on Ethereum events

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a26de50 View commit details
    Browse the repository at this point in the history

  30. Allow null pre-balances during Bridge pool escrow checks

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c67a656 View commit details
    Browse the repository at this point in the history

  31. Flow control of NAM transferred to Ethereum

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d3a4906 View commit details
    Browse the repository at this point in the history

  32. Replace ERC20 supply RPC query with atomic read of all flow control data

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    99fe477 View commit details
    Browse the repository at this point in the history

  33. Refactor get_erc20_flow_control to use EthBridgeQueries

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    2861e46 View commit details
    Browse the repository at this point in the history

  34. Add test_wnam_doesnt_mint_nuts() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    14556d7 View commit details
    Browse the repository at this point in the history

  35. Fix test_wrapped_nam_not_burned() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7efe3c2 View commit details
    Browse the repository at this point in the history

  36. Fix test_redeem_native_token() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a714fb3 View commit details
    Browse the repository at this point in the history

  37. Test that wrapped NAM is never minted

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0655085 View commit details
    Browse the repository at this point in the history

  38. Fix test_act_on_changes_storage_for_transfers_to_eth() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7a53732 View commit details
    Browse the repository at this point in the history

  39. Refactor Bridge pool tests to allow modifying pending transfer

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c0b0ed5 View commit details
    Browse the repository at this point in the history

  40. Add asset field to Balance

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d704d86 View commit details
    Browse the repository at this point in the history

  41. New Bridge pool VP unit tests for wrapped NAM

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d90a5ea View commit details
    Browse the repository at this point in the history

  42. Fix wNAM edge cases in Bridge pool VP unit tests

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    75cf448 View commit details
    Browse the repository at this point in the history

  43. Add invalidate_wnam_over_cap_tx() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fd1bf4d View commit details
    Browse the repository at this point in the history

  44. Add changelog for #1781

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    161cf43 View commit details
    Browse the repository at this point in the history

  45. Update ethbridge-rs to v0.22.0

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b30a877 View commit details
    Browse the repository at this point in the history

  46. Fix compilation errors to support new ethbridge-rs

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1a63f01 View commit details
    Browse the repository at this point in the history

  47. Test pending transfers and events have the same ABI encoding

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    91b2fef View commit details
    Browse the repository at this point in the history

  48. Changelog for #1789

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5678ee7 View commit details
    Browse the repository at this point in the history

  49. Move check_balance_changes to Bridge pool VP module

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    28dad92 View commit details
    Browse the repository at this point in the history

  50. Add token addr field to Bridge pool gas fees

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e102aff View commit details
    Browse the repository at this point in the history

  51. Fix compilation errors from prev commit

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b30fbeb View commit details
    Browse the repository at this point in the history

  52. Check correct gas fee token in Bridge pool transfers

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1850b07 View commit details
    Browse the repository at this point in the history

  53. Validate different gas fee tokens in Bridge pool VP

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bbff3cc View commit details
    Browse the repository at this point in the history

  54. Fix test_minting_wnam() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fdf00a8 View commit details
    Browse the repository at this point in the history

  55. Add misc Bridge pool VP tests

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7ec76d9 View commit details
    Browse the repository at this point in the history

  56. Fix bug in determine_escrow_checks and document corner cases

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5c8a030 View commit details
    Browse the repository at this point in the history

  57. Arbitrary gas fees in Ethereum events init_balances

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bad6a7c View commit details
    Browse the repository at this point in the history

  58. Test paying Bridge pool gas fees in ERC20 tokens

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    8745546 View commit details
    Browse the repository at this point in the history

  59. Update CLI args for Bridge pool transfers

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    9c3fbcc View commit details
    Browse the repository at this point in the history

  60. Standardize Bridge pool transfer CLI args

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4091b55 View commit details
    Browse the repository at this point in the history

  61. Make Bridge pool gas payer CLI arg optional

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5342193 View commit details
    Browse the repository at this point in the history

  62. Fix docstring 

    Co-authored-by: Jacob Turner <jacob.turner870@gmail.com>
    @sug0 @batconjurer
    sug0 and batconjurer committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ce21ebd View commit details
    Browse the repository at this point in the history

  63. Add DenominatedAmount::is_zero

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ba741a5 View commit details
    Browse the repository at this point in the history

  64. Fix the denomination of Bridge pool gas fees

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    27f07c8 View commit details
    Browse the repository at this point in the history

  65. Changelog for #1795

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    968f1a6 View commit details
    Browse the repository at this point in the history

  66. Retrieve the inner raw string on wrapped context values

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ee8cdb2 View commit details
    Browse the repository at this point in the history

  67. Bridge pool conversion rates table

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7a56f84 View commit details
    Browse the repository at this point in the history

  68. Convert gwei to tokens in Bridge pool conversion table

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3a15876 View commit details
    Browse the repository at this point in the history

  69. Fix Bridge pool construct_proof

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    d1ac064 View commit details
    Browse the repository at this point in the history

  70. Add context to CLI Bridge pool cmds

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    11aef0c View commit details
    Browse the repository at this point in the history

  71. Refactor recommendations to use EligibleRecommendation

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5898fb3 View commit details
    Browse the repository at this point in the history

  72. Rename generate to generate_recommendations

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4eae738 View commit details
    Browse the repository at this point in the history

  73. Fix Bridge pool proof warning voting power

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    0fc3e5d View commit details
    Browse the repository at this point in the history

  74. Factor out generate_eligible()

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ed3b5a3 View commit details
    Browse the repository at this point in the history

  75. Improve conversion rate query

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    fb89bff View commit details
    Browse the repository at this point in the history

  76. Avoid overflowing when calculating earned gwei amount

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ad57fab View commit details
    Browse the repository at this point in the history

  77. Add test_generate_eligible_happy_path() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3701ff7 View commit details
    Browse the repository at this point in the history

  78. Abstract generate_eligible unit tests with a helper fn

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    bf1a3be View commit details
    Browse the repository at this point in the history

  79. More conversion table unit tests

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    e7fa5ee View commit details
    Browse the repository at this point in the history

  80. Prohibit generating BP proofs when the signed root is outdated

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1b0dfee View commit details
    Browse the repository at this point in the history

  81. Fail recommending BP batch of txs if nonce is out of date

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    a0f5852 View commit details
    Browse the repository at this point in the history

  82. Store height when BP root was signed

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    371b1fe View commit details
    Browse the repository at this point in the history

  83. Check BP root's height when vote extension was signed

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    7b29efd View commit details
    Browse the repository at this point in the history

  84. Test the height of the BP proof stored in the db

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    00a859a View commit details
    Browse the repository at this point in the history

  85. Return recommendation data in generate_recommendations

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ac5d3ac View commit details
    Browse the repository at this point in the history

  86. Proper Debug impl for I256 values

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    b2a1e95 View commit details
    Browse the repository at this point in the history

  87. Add test_conversion_table_profit_margin() unit test

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    eff9785 View commit details
    Browse the repository at this point in the history

  88. Ignore invalid conversion rates

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    225c885 View commit details
    Browse the repository at this point in the history

  89. Add changelog for #1811

    @sug0
    sug0 committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c4e4819 View commit details
    Browse the repository at this point in the history