Denominate non-whitelisted NUT amounts #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batconjurer
approved these changes
Aug 31, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/nut-denom: Changelog for #1853 Translate NUT denoms to ERC20 denoms
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/nut-denom: Changelog for #1853 Translate NUT denoms to ERC20 denoms
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tiago/nut-denom: Changelog for #1853 Translate NUT denoms to ERC20 denoms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
If some ERC20 has never been whitelisted before, no denomination will be available for it in Namada's storage. To transfer the equivalent NUT back to Ethereum, the user will have to specify a denominated amount. Whereas before, the denomination would be the same as NAM's (therefore, 6), it is now set to 0.
NOTE: Change the base to
mainonce reviewed.Indicate on which release or other PRs this topic is based on
#1852
Checklist before merging to
draft