Retransmit some timed out Ethereum events #1899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of accounting for votes on Ethereum tallies based on the average voting power available across all epochs the tally took place in, we account for the maximum voting power found across all these epochs.
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
sug0
force-pushed
the
tiago/retransmit-expired-eth-events
branch
from
ebcd8f6
to
69b064c
Compare
tzemanovic
previously approved these changes
Sep 20, 2023
batconjurer
reviewed
Sep 21, 2023
batconjurer
reviewed
Sep 21, 2023
sug0
force-pushed
the
tiago/retransmit-expired-eth-events
branch
from
69b064c
to
415c902
Compare
batconjurer
previously approved these changes
Sep 21, 2023
sug0
dismissed stale reviews from batconjurer and tzemanovic
The base branch was changed.
sug0
force-pushed
the
tiago/retransmit-expired-eth-events
branch
from
415c902
to
be4985a
Compare
Closed
sug0
added a commit
that referenced
this pull request
Sep 21, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Sep 25, 2023
* origin/tiago/retransmit-expired-eth-events: Changelog for #1899 Change wording on Ethereum tally docstr Check if eth events to retransmit are empty Add test_commit_broadcasts_expired_eth_events() unit test Add test_delete_expired_tally() unit test Add deleted eth events with >1/3 voting power to expired queue Return deleted tally payload if its voting power is >1/3 Broadcast expired txs Factor out signing eth events vote extensions in the shell Refactor broadcasting protocol txs Add expired txs queue to storage Implement queue of expired txs
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In case an Ethereum event times out with$>\frac{1}{3}$ voting power accumulated behind it, it may be proposed once more during the COMMIT phase of the protocol, such that its state updates may be reconsidered. BFT protocols often have this notion of weak certificates on proposed data (e.g. see Sousa et al. in Mod-SMaRt).
Indicate on which release or other PRs this topic is based on
Based on #1865
Checklist before merging to
draft