Fix transmitting protocol txs if validator node #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
converted the pr to draft to add a regression test |
sug0
force-pushed
the
tiago/fix-protocol-txs
branch
from
d2a704a
to
9169b3a
Compare
2 tasks
sug0
force-pushed
the
tiago/fix-protocol-txs
branch
from
9169b3a
to
2368969
Compare
sug0
added a commit
that referenced
this pull request
Oct 13, 2023
Closed
29 tasks
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tiago/fix-protocol-txs: Changelog for #1964 Add test_broadcast_valset_upd_inspite_oracle_off() unit test Allow shutting off the Ethereum oracle in tests Fix transmitting protocol txs if validator node
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
A bug was introduced by #1899 where no protocol txs are broadcasted to the network, unless the Ethereum oracle is enabled. This PR fixes the underlying issue.
Indicate on which release or other PRs this topic is based on
v0.23.0Checklist before merging to
draft