Phase out Halt abstractions
#1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
a9837e9
to
ef4fbc0
Compare
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
ef4fbc0
to
d128f95
Compare
tzemanovic
reviewed
Sep 29, 2023
tzemanovic
reviewed
Sep 29, 2023
tzemanovic
reviewed
Sep 29, 2023
tzemanovic
reviewed
Sep 29, 2023
tzemanovic
reviewed
Sep 29, 2023
tzemanovic
previously approved these changes
Sep 29, 2023
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
ccfb134
to
e3299fa
Compare
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
e3299fa
to
adbeb20
Compare
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
adbeb20
to
d305801
Compare
2 tasks
batconjurer
reviewed
Oct 9, 2023
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
d305801
to
13dc4c1
Compare
… added null IO implementation.
… shielded context.
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
sug0
changed the base branch from
tiago/move-eth-to-sdk
to
murisi/sdk-refactor-rebased
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
13dc4c1
to
af1fa0e
Compare
sug0
added a commit
that referenced
this pull request
Oct 13, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tiago/phase-out-try-halt: Changelog for #1953 Echo SDK errors to stdout Internal macros SDK module Apply suggestions from code review Remove halt abstraction from the SDK Phase out Halt and its cousins from the SDK Add new SDK errors
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Haltwas an abstraction conceived when the code we currently deem the "SDK" was initially ported fromappstoshared. When the SDK code lived inapps, many error scenarios resulted in the client aborting withsafe_exit(1), so a close approximation of this behavior was a halt instruction of sorts, which, as the name implies, would halt all execution.However, since then, the SDK has improved in terms of usability. Panics and other odd bits were replaced with a proper
Errortype, returned from aResultmonad. So, this PR attempts to remove theHaltlegacy code, and integrate the code that depended on it with the new SDKErrortype.Indicate on which release or other PRs this topic is based on
Based on #1963
Checklist before merging to
draft