Add validation to Bridge pool transfers #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
previously approved these changes
Sep 29, 2023
batconjurer
reviewed
Oct 9, 2023
batconjurer
previously approved these changes
Oct 9, 2023
sug0
force-pushed
the
tiago/bp-client-validation
branch
from
f51f0f5
to
96ac73d
Compare
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
d305801
to
13dc4c1
Compare
sug0
force-pushed
the
tiago/bp-client-validation
branch
from
96ac73d
to
ca4c2c6
Compare
… added null IO implementation.
… shielded context.
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
sug0
force-pushed
the
tiago/phase-out-try-halt
branch
from
13dc4c1
to
af1fa0e
Compare
sug0
force-pushed
the
tiago/bp-client-validation
branch
from
ca4c2c6
to
bbab1c4
Compare
sug0
added a commit
that referenced
this pull request
Oct 13, 2023
Closed
29 tasks
Fraccaman
dismissed stale reviews from batconjurer and tzemanovic
The base branch was changed.
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* origin/tiago/bp-client-validation: Changelog for #1957 Validate Bridge pool client transfers Make ERC20 flow control fields public Check ERC20 token caps Add new SDK error types Factor out validate_bridge_pool_tx() Factor out submit_bridge_pool_tx()
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #1800
Adds validation to Bridge pool transfers.
Indicate on which release or other PRs this topic is based on
Based on #1953
Checklist before merging to
draft