Replay protection delay write #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: reviewed in #2108 (review) for the correct diff |
tzemanovic
previously approved these changes
Nov 7, 2023
grarco
added a commit
that referenced
this pull request
Nov 7, 2023
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
b9e4b7a
to
8cbba5c
Compare
grarco
added a commit
that referenced
this pull request
Nov 7, 2023
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
8cbba5c
to
b9e4b7a
Compare
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
b9e4b7a
to
c0e14eb
Compare
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
c0e14eb
to
6c1d784
Compare
grarco
added a commit
that referenced
this pull request
Nov 7, 2023
Closed
tzemanovic
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #2036.
Moves the write of the decrypted tx hash after its execution in
finalize_blockand introduces a new check to prevent applying the same decrypted tx more than once.Updates unit tests.
Indicate on which release or other PRs this topic is based on
Based on #1905
Checklist before merging to
draft