Grarco/replay protection delay write REVIEW ONLY #2108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwgoes
commented
Nov 7, 2023
There was a problem hiding this comment.
Only a minor comment, but @tzemanovic should also review this.
| protocol::Error::ReplayAttempt(_), | ||
| ) = msg | ||
| { | ||
| // Remove the wrapper hash but keep the inner tx |
There was a problem hiding this comment.
Can we further explicate this comment to explain why this is safe? (as I understand it, because the inner transaction hash will still be in storage, and block any future replay)
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
2 times, most recently
from
8cbba5c
to
b9e4b7a
Compare
grarco
force-pushed
the
grarco/replay-protection-improvements
branch
2 times, most recently
from
1e91762
to
12aeb34
Compare
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
b9e4b7a
to
c0e14eb
Compare
grarco
force-pushed
the
grarco/replay-protection-improvements
branch
from
12aeb34
to
1878a4c
Compare
grarco
force-pushed
the
grarco/replay-protection-delay-write
branch
from
c0e14eb
to
6c1d784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW ONLY