Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change validator's consensus key #2137

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Nov 9, 2023

Describe your changes

Closes #36.

TODO:

  • e2e test? (RIP)

Indicate on which release or other PRs this topic is based on

v0.26.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone added the PoS label Nov 9, 2023
@brentstone brentstone changed the title change a validator's consensus key Change validator's consensus key Nov 9, 2023
brentstone added a commit that referenced this pull request Nov 9, 2023
@brentstone
Copy link
Collaborator Author

@tzemanovic @cwgoes Should the validator be required to explicitly provide a new consensus key or should we allow a new consensus key to be generated for them as well?

@cwgoes
Copy link
Contributor

cwgoes commented Nov 9, 2023

@tzemanovic @cwgoes Should the validator be required to explicitly provide a new consensus key or should we allow a new consensus key to be generated for them as well?

They should be required to explicitly provide one, only experienced validators should be doing this.

@brentstone
Copy link
Collaborator Author

They should be required to explicitly provide one, only experienced validators should be doing this.

@adrianbrink

brentstone added a commit that referenced this pull request Nov 11, 2023
@brentstone brentstone mentioned this pull request Nov 13, 2023
brentstone added a commit that referenced this pull request Nov 15, 2023
* brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key
brentstone added a commit that referenced this pull request Nov 15, 2023
* brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key
Fraccaman pushed a commit that referenced this pull request Nov 20, 2023
* origin/brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key

# Conflicts:
#	proof_of_stake/src/tests.rs
Fraccaman pushed a commit that referenced this pull request Nov 20, 2023
* origin/brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key

# Conflicts:
#	proof_of_stake/src/tests.rs
Fraccaman pushed a commit that referenced this pull request Nov 20, 2023
* origin/brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key

# Conflicts:
#	proof_of_stake/src/tests.rs
Fraccaman pushed a commit that referenced this pull request Nov 20, 2023
* origin/brent/consensus-key-change:
  benches: consensus key must be ed25519
  add pos error
  add unit test that covers `validator_set_update_tendermint`
  changelog: add #2137
  change a validator's consensus key

# Conflicts:
#	proof_of_stake/src/tests.rs
@tzemanovic tzemanovic merged commit b9b9025 into main Nov 21, 2023
12 of 14 checks passed
@tzemanovic tzemanovic deleted the brent/consensus-key-change branch November 21, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoS validator consensus key change
3 participants