RPC shell sub-router #569

tzemanovic · 2022-10-07T16:13:58Z

based on #553

This PR moves the current RPC paths into a "shell" sub-router. This is a breaking change for all the current RPC paths which are all prefixed with "/shell" now :

"/shell/dry_run_tx"
"/shell/epoch"
"/shell/value"
"/shell/prefix"
"/shell/has_key"

This is to take advantage of tree-based pattern matching, organize code with the handlers and to add other sub-routers. Concretely, I'll be adding "/vp" sub-router with "/pos" inside it for PoS specific queries next.

relevant commits:

3835cd5 - moves current patterns under "shell" sub-router
276845c - simplified handlers to be able to specify (with_options $handler) for handlers that want to use the request/response, otherwise it's not expected in the handler's signature

This adds a new feature "async-client" and "tendermint-rpc" to shared crate that if enabled generate async client code for all router's handler methods, and implements it for tendermint-rpc client, respectively.

tzemanovic · 2022-10-24T13:49:44Z

pls update wasm

* tomas/rpc-sub-shell: [ci] wasm checksums update router: add `with_options` for handlers that use request/response move the current RPC patterns under "shell" sub-router

Namada 0.9.0 * tag 'v0.9.0': Namada 0.9.0 release.sh: list prerequisites in a comment changelog: add #569 queries: fix unused import in wasm build Fixes pgf council vote format Rwnames `type`, adds examples Custom proposal and vote memos in governance spec RPC: fix storage_value to return data as read w/o re-encoding in Option [ci] wasm checksums update router: add `with_options` for handlers that use request/response move the current RPC patterns under "shell" sub-router make fmt Log at INFO by default for namadan Add changelog ledger/queries: comment out `println`s for router path matching dbg ledger/queries: fix require_no_proof doc-string ci: fix workflow name ci: fix mold usage Update README.md some doc comment edits fix: namadan should log at info by default ci: use mold linker changelog: add #632 feat: change native token to nam [ci] wasm checksums update changelog: add #671 add back consensus timeout commit config for abciplus switch to tendermint-rs with consensus timeout wasm: update checksums changelog: add #553 apps: replace RPC module and its handlers with new queries mod shared: add new queries router macro to replicate handwritten RPC paths add deps for router macro and update `Cargo.lock`s protocol: update imports and add missing rustdoc move ledger's protocol module into shared crate ci: invalide cf cache fix broken link split back out the core VPs Modify specs test/e2e/helpers: add a helper to query and parse block height changelog: add #658 client: add a block query to print hash, height and time of a block wasm: update checksums.json [fix]: Fixed the borsh schema for libsecp256k signatures [feat]: Added the recovery id to secp256k signatures [ci] wasm checksums update feat: remove nft

- changed to type of the proof in query Response for more convenient type Namada 0.9.0 * tag 'v0.9.0': Namada 0.9.0 release.sh: list prerequisites in a comment changelog: add #569 queries: fix unused import in wasm build Fixes pgf council vote format Rwnames `type`, adds examples Custom proposal and vote memos in governance spec RPC: fix storage_value to return data as read w/o re-encoding in Option [ci] wasm checksums update router: add `with_options` for handlers that use request/response move the current RPC patterns under "shell" sub-router make fmt Log at INFO by default for namadan Add changelog ledger/queries: comment out `println`s for router path matching dbg ledger/queries: fix require_no_proof doc-string ci: fix workflow name ci: fix mold usage Update README.md some doc comment edits fix: namadan should log at info by default ci: use mold linker changelog: add #632 feat: change native token to nam [ci] wasm checksums update changelog: add #671 add back consensus timeout commit config for abciplus switch to tendermint-rs with consensus timeout wasm: update checksums changelog: add #553 apps: replace RPC module and its handlers with new queries mod shared: add new queries router macro to replicate handwritten RPC paths add deps for router macro and update `Cargo.lock`s protocol: update imports and add missing rustdoc move ledger's protocol module into shared crate ci: invalide cf cache fix broken link split back out the core VPs Modify specs test/e2e/helpers: add a helper to query and parse block height changelog: add #658 client: add a block query to print hash, height and time of a block wasm: update checksums.json [fix]: Fixed the borsh schema for libsecp256k signatures [feat]: Added the recovery id to secp256k signatures [ci] wasm checksums update feat: remove nft

…wards * origin/main: (632 commits) ci: use commit hash instead of pr number ci: fix binaries sha changelog: add #720 fix: rename correctly in debug wasm build Namada 0.9.0 release.sh: list prerequisites in a comment changelog: add #569 queries: fix unused import in wasm build Fixes pgf council vote format Rwnames `type`, adds examples Custom proposal and vote memos in governance spec RPC: fix storage_value to return data as read w/o re-encoding in Option [ci] wasm checksums update router: add `with_options` for handlers that use request/response move the current RPC patterns under "shell" sub-router make fmt Log at INFO by default for namadan Add changelog ledger/queries: comment out `println`s for router path matching dbg ledger/queries: fix require_no_proof doc-string ci: fix workflow name ci: fix mold usage Update README.md some doc comment edits fix: namadan should log at info by default ci: use mold linker changelog: add #632 feat: change native token to nam [ci] wasm checksums update changelog: add #671 add back consensus timeout commit config for abciplus switch to tendermint-rs with consensus timeout wasm: update checksums changelog: add #553 apps: replace RPC module and its handlers with new queries mod shared: add new queries router macro to replicate handwritten RPC paths add deps for router macro and update `Cargo.lock`s protocol: update imports and add missing rustdoc move ledger's protocol module into shared crate ci: invalide cf cache fix broken link split back out the core VPs Modify specs test/e2e/helpers: add a helper to query and parse block height changelog: add #658 client: add a block query to print hash, height and time of a block Namada 0.8.1 changelog: add #510 [feat]: Make process proposal stateless test/e2e: fix node_connectivity test test/e2e: update expected string for non-validator node [fix]: Removed unnecessary patches in wasm [feat]: Patched tendermint-rs and ibc-rs to compatible versions app: set "namada" set default bin for `cargo run` wasm: update checksums.json [fix]: Fixed the borsh schema for libsecp256k signatures [feat]: Added the recovery id to secp256k signatures [ci] wasm checksums update feat: remove nft fix: rename anoma to namada, remove author print CI: add workaround for release build missing git tag Namada 0.8.0 changelog: add #547 wasm: update checksums [chore]: Lints and formatting [fix]: Fixed proof specs for non-existence proofs [fix]: Update the main tree when deleting a key [fix]: Fixed last ibc unit test [fix]: Fixed some tests. [feat]: Refactored the merkle tree into a more maintainable multi-store build: pin abciplus library revisions wasm: update checksums.json ci: standardize on one tendermint hash formatting changes change `L_{NAM}` -> `L_{PoS}` for clarity and consistency change inflation `I` to have units of tokens per epoch fix term ordering in error calculation Remove other `:=` in favor of `=` distinguish new and old inflation rates with a prime fix md rendering correct the shielded pool error calculation change storing of error to storing of token ratios (same procedure) fix: `I` is percent per annum distinguish between `K` in storage and `K` as intermediate value in inflation calculation Use `I` for inflation rates, as `R` reserved for locked ratios specify some default values, other small edits release: add scripts/release.sh release: add release.toml to wasm workspace and wasm_for_tests release: don't tag from cargo release release: update release.toml for cargo-release 0.21.4 wasm: remove tx_from_intent build wasm: repair wasm checksums Add changelog Add changelog Fix TransactionGasExceededed typo changelog: add #594 shared/storage: fix the height recorded for a new epoch Apply suggestions from code review changelog: add #590 wasm/tx_bond: fix delegation detection to compare source and validator ...

tzemanovic mentioned this pull request Oct 7, 2022

RPC: add PoS queries #570

Merged

tzemanovic force-pushed the tomas/rpc-sub-shell branch from 6254244 to da6cc62 Compare October 11, 2022 10:22

tzemanovic force-pushed the tomas/rpc-sub-shell branch 2 times, most recently from 2c42384 to 276845c Compare October 24, 2022 09:56

tzemanovic added 7 commits October 24, 2022 11:58

move ledger's protocol module into shared crate

9b5a8d9

protocol: update imports and add missing rustdoc

84777a2

add deps for router macro and update Cargo.locks

2b36531

This adds a new feature "async-client" and "tendermint-rpc" to shared crate that if enabled generate async client code for all router's handler methods, and implements it for tendermint-rpc client, respectively.

shared: add new queries router macro to replicate handwritten RPC paths

0c9b0bc

apps: replace RPC module and its handlers with new queries mod

c593917

changelog: add #553

66c632c

wasm: update checksums

6813526

tzemanovic force-pushed the tomas/rpc-sub-shell branch from 276845c to eb921d3 Compare October 24, 2022 10:41

tzemanovic marked this pull request as ready for review October 24, 2022 13:49

tzemanovic added a commit that referenced this pull request Oct 24, 2022

Merge branch 'tomas/rpc-sub-shell' (#569)

19d1b53

* tomas/rpc-sub-shell: [ci] wasm checksums update router: add `with_options` for handlers that use request/response move the current RPC patterns under "shell" sub-router

tzemanovic mentioned this pull request Oct 24, 2022

PoS integration #677

Closed

9 tasks

brentstone and others added 3 commits October 25, 2022 14:08

some doc comment edits

3b0117e

ledger/queries: fix require_no_proof doc-string

c1d8f04

ledger/queries: comment out printlns for router path matching dbg

ddc62be

tzemanovic mentioned this pull request Oct 28, 2022

RPC queries router #553

Merged

tzemanovic and others added 5 commits October 28, 2022 18:55

make fmt

a16180f

move the current RPC patterns under "shell" sub-router

e71c775

router: add with_options for handlers that use request/response

e0f3187

[ci] wasm checksums update

c87d5bf

RPC: fix storage_value to return data as read w/o re-encoding in Option

a966969

tzemanovic force-pushed the tomas/rpc-sub-shell branch from 0f43944 to a966969 Compare October 28, 2022 17:05

juped force-pushed the tomas/rpc-sub-shell branch 3 times, most recently from a46e2d2 to 89fd030 Compare October 31, 2022 15:56

juped added a commit that referenced this pull request Oct 31, 2022

changelog: add #569

daef7df

tzemanovic and others added 2 commits October 31, 2022 12:48

queries: fix unused import in wasm build

5454327

changelog: add #569

27f324c

juped force-pushed the tomas/rpc-sub-shell branch from daef7df to 27f324c Compare October 31, 2022 16:48

juped merged commit 3a8700b into main Oct 31, 2022

juped deleted the tomas/rpc-sub-shell branch October 31, 2022 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RPC shell sub-router #569

RPC shell sub-router #569

tzemanovic commented Oct 7, 2022 •

edited

Loading

tzemanovic commented Oct 24, 2022

RPC shell sub-router #569

RPC shell sub-router #569

Conversation

tzemanovic commented Oct 7, 2022 • edited Loading

tzemanovic commented Oct 24, 2022

tzemanovic commented Oct 7, 2022 •

edited

Loading