Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: namadan should log at info by default #702

Merged
merged 3 commits into from
Oct 31, 2022
Merged

fix: namadan should log at info by default #702

merged 3 commits into from
Oct 31, 2022

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Oct 27, 2022 •
edited
Loading

Right now, running namadan does not show INFO logs by default, this PR fixes this.

@james-chf james-chf marked this pull request as ready for review October 27, 2022 14:34
@tzemanovic
Copy link
Member

strange flakiness in CI - for the e2e test https://github.com/anoma/namada/actions/runs/3346594039/jobs/5543588172, it failed on

    0: Reached a timeout for expect type of command
       Needle: Tendermint node started

but I can see it in the logs?!

tzemanovic
tzemanovic approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@juped juped merged commit 40cf216 into main Oct 31, 2022
@juped juped deleted the james/mainline/fix-default-node-logging branch October 31, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james-chf @tzemanovic @juped