Fix compiling with the abcipp feature flag
#754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
force-pushed
the
james/mainline/fix-abcipp
branch
from
9e77c12
to
2604a91
Compare
4 tasks
4 tasks
tzemanovic
previously approved these changes
Nov 17, 2022
tzemanovic
added a commit
that referenced
this pull request
Nov 17, 2022
- Additionally updated imports in - `shared/src/ledger/queries/shell.rs` - `apps/src/lib/client/types.rs` * james/mainline/fix-abcipp: Add changelog Add check-abcipp command Use ferveo-tpke flag to stop tendermint-rpc being pulled into wasm First attempt at fixing shared abcipp
4 tasks
4 tasks
4 tasks
4 tasks
tzemanovic
added a commit
that referenced
this pull request
Nov 25, 2022
* james/mainline/fix-abcipp: Add changelog Add check-abcipp command Use ferveo-tpke flag to stop tendermint-rpc being pulled into wasm First attempt at fixing shared abcipp
Closed
james-chf
force-pushed
the
james/mainline/fix-abcipp
branch
from
2604a91
to
04b313a
Compare
|
I've force pushed a rebase onto namada v0.10.1. The |
james-chf
commented
Nov 28, 2022
| @@ -60,7 +68,7 @@ clippy-abcipp: | |||
| $(cargo) +$(nightly) clippy --all-targets \ | |||
| --manifest-path ./shared/Cargo.toml \ | |||
| --no-default-features \ | |||
| --features "testing wasm-runtime abcipp ibc-mocks-abcipp" && \ | |||
| --features "testing wasm-runtime abcipp ibc-mocks-abcipp ferveo-tpke" && \ | |||
There was a problem hiding this comment.
We don't actually need this ferveo-tpke feature it seems when this PR is merged for v0.11 as in #830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #497
namadacrate to importtendermint-rscrates via a facadetendermint-rpcshould be used only conditionally on theferveo-tpkeflag being enabled, so that it won't be pulled into wasm builds (use of this flag is a hack that we should remove/replace in this PR or after)make check-abcipptargetWe could start running
make check-abcippin CI after this PR lands