Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run make check-abcipp in CI #824

Merged
merged 2 commits into from Dec 8, 2022
Merged

Run make check-abcipp in CI #824

merged 2 commits into from Dec 8, 2022

Conversation

james-chf
Copy link
Contributor

@james-chf james-chf commented Nov 25, 2022

Implicitly depends on #754, which adds make check-abcipp

This PR makes it so that we run make check-abcipp in CI, to ensure that code continues to compile with the abcipp feature.

@james-chf james-chf linked an issue Nov 25, 2022 that may be closed by this pull request
4 tasks
@james-chf james-chf closed this Dec 1, 2022
@james-chf james-chf deleted the james/mainline/abcipp-ci branch December 1, 2022 16:57
@james-chf james-chf restored the james/mainline/abcipp-ci branch December 7, 2022 11:03
@james-chf james-chf reopened this Dec 7, 2022
@james-chf james-chf marked this pull request as ready for review December 7, 2022 11:03
tzemanovic
tzemanovic previously approved these changes Dec 7, 2022
@james-chf
Copy link
Contributor Author

I thought this was rebased on v0.11 already, will rebase now

@tzemanovic tzemanovic merged commit f9d72f0 into main Dec 8, 2022
@tzemanovic tzemanovic deleted the james/mainline/abcipp-ci branch December 8, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix compiling with abcipp and set up CI to check it
2 participants