Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve landing page globe performance #118

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

Kit-p
Copy link
Contributor

@Kit-p Kit-p commented Oct 24, 2022

Description

Fix a performance issue where the globe is rotating in very low fps when using production build of React.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Owner

@anomic30 anomic30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@anomic30 anomic30 merged commit e8868ac into anomic30:main Oct 24, 2022
@anomic30 anomic30 added bug Something isn't working hacktoberfest-accepted Accepted for Hacktoberfest 2022 labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest-accepted Accepted for Hacktoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants