Some changes and fixes for node-xmpp-via-bosh #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
December 15, 2011 12:55
Fixed the following issues: - Added URL to the constructor of the component in favor of hostname and port. - Fixed some issues that I was having when starting a session. - The send method now first gets the top the XML structure. - Changed the example to work with the new API.
anoopc
added a commit
that referenced
this pull request
Mar 31, 2012
Some changes and fixes for node-xmpp-via-bosh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Anoop,
I came across your work on XMPP via BOSH but was not able to use it completely. I had some issues with the session setup and noticed a hardcoded 'localhost' still in the code.
I fixed these issue and the code is working for me now. I have tested it with an Openfire XMPP server.
Some other issues that I fixed are:
Feel free to incorporate my code if you like.
Best regards,
Eelco