Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html title #12

Merged
merged 1 commit into from
Feb 24, 2024
Merged

html title #12

merged 1 commit into from
Feb 24, 2024

Conversation

hyukim17
Copy link
Contributor

  • adds html_title to Report class so that we can customize the html title of a report
  • renames nb_name to html_title in the ReportGenerator, as it was only being used for setting the html title anyway

Copy link
Collaborator

@yanovs yanovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanovs
Copy link
Collaborator

yanovs commented Feb 22, 2024

@hyukim17 I think these errors have nothing to do with your changes. I'm going to fix them, add Python 3.12 support, add a new testing bundle with the latest versions of libraries, and then I'll do a release.

@hyukim17
Copy link
Contributor Author

LGTM!

Cool, so you'll end up doing the merge?

@yanovs
Copy link
Collaborator

yanovs commented Feb 23, 2024

LGTM!

Cool, so you'll end up doing the merge?

Yeah, I'll do the merge.

@yanovs yanovs merged commit e27dbe6 into ansatzcapital:main Feb 24, 2024
2 of 19 checks passed
@hyukim17
Copy link
Contributor Author

What's the process for deploying a new wheel?

@yanovs
Copy link
Collaborator

yanovs commented Feb 25, 2024

What's the process for deploying a new wheel?

I just released v0.5.0: https://github.com/ansatzcapital/leda/releases/tag/v0.5.0. It's now available via pypi: https://pypi.org/project/leda/0.5.0/.

The process is simply to create a new GitHub release here: https://github.com/ansatzcapital/leda/releases. (GitHub has a button to auto-generate release notes, which I use.) Then the CI will do the rest: https://github.com/ansatzcapital/leda/actions/runs/8039217496.

Note that in this case, we just crossed the 100MB limit for the sdist--but not the whl--file, so only the wheel was uploaded. I'll look into fixing this.

Note also that I added a scheduled daily run here so that external changes don't silently break the CI tests in between PRs, as they did in this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants