Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow html title to be different from nb_name #11

Closed
hyukim17 opened this issue Feb 17, 2024 · 2 comments
Closed

allow html title to be different from nb_name #11

hyukim17 opened this issue Feb 17, 2024 · 2 comments

Comments

@hyukim17
Copy link
Contributor

Currently, the <title> field in the published html is always the same as the notebook name. However, it is common to pass changing parameters to the same notebook file, resulting in different outputs that would be better described with custom html <title> fields.

I have a branch that would fix this, so I could submit a PR if I can join the collaborator list.

@yanovs
Copy link
Collaborator

yanovs commented Feb 19, 2024

Sounds good! Have you tried creating a fork and then making a PR from your branch there (with this repo's main as the target)? If that doesn't work, we'll need @adshieh's help with group/project settings, I think.

@hyukim17
Copy link
Contributor Author

Sounds good! Have you tried creating a fork and then making a PR from your branch there (with this repo's main as the target)? If that doesn't work, we'll need @adshieh's help with group/project settings, I think.

Okay, I created it here: #12

@yanovs yanovs closed this as completed Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants