Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support For Additional Placement Options and LicenseSpecifications #1824

Closed
1 task done
mfortin opened this issue Oct 21, 2023 · 0 comments · Fixed by #1825
Closed
1 task done

Support For Additional Placement Options and LicenseSpecifications #1824

mfortin opened this issue Oct 21, 2023 · 0 comments · Fixed by #1825

Comments

@mfortin
Copy link
Contributor

mfortin commented Oct 21, 2023 •
edited
Loading

Summary

In order to launch mac instances using the amazon.aws.ec2_instance module, support for HostGroupResourceArn placement option and LicensConfigurations would be required as an alternative to only specifying tenancy as dedicated to offer more control on instance launch.

Issue Type

Feature Idea

Component Name

ec2_instance

Additional Information

- name: start a mac instance with a host resource group and license configuration
  amazon.aws.ec2_instance:
    name: "public-compute-instance"
    key_name: "prod-ssh-key"
    vpc_subnet_id: subnet-5ca1ab1e
    instance_type: mac1.metal
    security_group: default
    placement:
      hostresourcegrouparn: arn:aws:resource-groups:us-east-1:123456789012:group/MyResourceGroup
    license_specifications:
      - license_configuration_arn: arn:aws:license-manager:us-east-1: 123456789012:license-configuration:lic-0123456789
    image_id: ami-123456
    tags:
      Environment: Testing

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@mfortin mfortin mentioned this issue Oct 21, 2023
Merged
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
@gsimon75
cloudfront_distribution: now honours the enabled setting (ansible-col…
5594769 
…lections#1824)

cloudfront_distribution: now honours the enabled setting

SUMMARY
Fixes: ansible-collections#1823
The enabled: false setting was ignored, because here we were falling back to the default True not only when the setting was None, but also when it was False.
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this issue Oct 30, 2023
@mfortin
ec2_instance - add support for placement and `license_specification…
c9fd4b7 
…s` (#1825)

ec2_instance - add support for `placement` and `license_specifications`

SUMMARY

Adding placement options and license specifications support

Fixes #1824
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Math Fortin
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ec2_instance - add support for placement and license_specifications mfortin/amazon.aws
2 participants
@gravesm @mfortin