ec2_instance - add support for placement and license_specifications
#1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
changed the title
placement and license_specifications
tremble
requested changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks for taking the time to submit this PR,
If possible, please could you add some integration tests for the placement options?
The tests are just Ansible roles living in:
tests/integration/targets
There's already a number of ec2_instance_... tests in there.
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…s#1826) dynamodb_table: secondary indexes are now created SUMMARY Fixes: ansible-collections#1825 Possibly by a typo, the index definition being checked was over-defined by an empty dict here. Without that line the index processing proceeds fine. ISSUE TYPE Bugfix Pull Request COMPONENT NAME dynamodb_table Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz <git@osuv.de>
yugesk
pushed a commit
to yugesk/amazon.aws
that referenced
this pull request
Oct 24, 2023
hakbailey
previously requested changes
Oct 26, 2023
There was a problem hiding this comment.
See a couple of inline comments, but one larger request: instead of adding new modules here, can we use the existing ec2_placement_group and ec2_placement_group_info modules in the community.aws collection?
tests/integration/targets/ec2_instance_license_specifications/tasks/main.yml
Show resolved
Hide resolved
mfortin
commented
Oct 27, 2023
tests/integration/targets/ec2_instance_license_specifications/tasks/main.yml
Show resolved
Hide resolved
alinabuzachis
approved these changes
Oct 30, 2023
hakbailey
approved these changes
Oct 30, 2023
softwarefactory-project-zuul
bot
merged commit c9fd4b7
into
ansible-collections:main
37 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding placement options and license specifications support
Fixes #1824
ISSUE TYPE
COMPONENT NAME
ec2_instance
ADDITIONAL INFORMATION