Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host option in tenancy under placement #1990

Closed
1 task done
tuxinblue opened this issue Feb 22, 2024 · 0 comments · Fixed by #2026
Closed
1 task done

host option in tenancy under placement #1990

tuxinblue opened this issue Feb 22, 2024 · 0 comments · Fixed by #2026
Assignees
Labels
feature This issue/PR relates to a feature request jira

Comments

@tuxinblue
Copy link

Summary

AWS has three type of options on tenancy: Shared, Dedicated, Dedicated Host.
If we use a dedicated host with auto-placement option, we can allocate a machine to untargeted a dedicated host.
We should set tenancy to dedicated host to use this function.

ec2_instance module already have shared and dedicated (default and dedicated) options.
I think it should have a dedicated host (host) option as well.

https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_instance.py#L258-L262

Issue Type

Feature Idea

Component Name

ec2_instance

Additional Information

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@gravesm gravesm added feature This issue/PR relates to a feature request jira and removed needs_triage labels Feb 27, 2024
@mandar242 mandar242 self-assigned this Mar 25, 2024
softwarefactory-project-zuul bot pushed a commit that referenced this issue Apr 22, 2024
add support for host option in placement.tenancy

SUMMARY

Add host option in tenancy under placement.
Resolves #1990

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION


https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
patchback bot pushed a commit that referenced this issue Apr 22, 2024
add support for host option in placement.tenancy

SUMMARY

Add host option in tenancy under placement.
Resolves #1990

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
(cherry picked from commit 096b026)
softwarefactory-project-zuul bot pushed a commit that referenced this issue Apr 22, 2024
[PR #2026/096b0267 backport][stable-7] add support for host option in placement.tenancy

This is a backport of PR #2026 as merged into main (096b026).
SUMMARY

Add host option in tenancy under placement.
Resolves #1990

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION


https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request jira
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants