Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for host option in placement.tenancy #2026

Conversation

mandar242
Copy link
Contributor

SUMMARY

Add host option in tenancy under placement.

Resolves #1990

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_instance

ADDITIONAL INFORMATION

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html

The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Copy link

github-actions bot commented Mar 25, 2024

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/346c5bd8e85b42ea87baae7855f03f8e

✔️ ansible-galaxy-importer SUCCESS in 5m 01s
✔️ build-ansible-collection SUCCESS in 15m 47s
✔️ ansible-test-splitter SUCCESS in 6m 17s
✔️ integration-amazon.aws-1 SUCCESS in 19m 43s
✔️ integration-amazon.aws-2 SUCCESS in 8m 13s
✔️ integration-amazon.aws-3 SUCCESS in 10m 22s
✔️ integration-amazon.aws-4 SUCCESS in 7m 54s
✔️ integration-amazon.aws-5 SUCCESS in 8m 46s
✔️ integration-amazon.aws-6 SUCCESS in 6m 10s
✔️ integration-amazon.aws-7 SUCCESS in 7m 47s
✔️ integration-amazon.aws-8 SUCCESS in 12m 36s
✔️ integration-amazon.aws-9 SUCCESS in 11m 21s
✔️ integration-amazon.aws-10 SUCCESS in 9m 20s
✔️ integration-amazon.aws-11 SUCCESS in 7m 36s
✔️ integration-amazon.aws-12 SUCCESS in 13m 48s
✔️ integration-amazon.aws-13 SUCCESS in 11m 00s
✔️ integration-amazon.aws-14 SUCCESS in 11m 30s
✔️ integration-amazon.aws-15 SUCCESS in 10m 20s
✔️ integration-amazon.aws-16 SUCCESS in 8m 32s
✔️ integration-amazon.aws-17 SUCCESS in 7m 06s
✔️ integration-amazon.aws-18 SUCCESS in 7m 44s
✔️ integration-amazon.aws-19 SUCCESS in 8m 02s
Skipped 25 jobs

@@ -362,7 +362,7 @@
description: Type of tenancy to allow an instance to use. Default is shared tenancy. Dedicated tenancy will incur additional charges.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a note where you specify that support for host has been added in 7.6.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be 8.0.0 instead since we are aiming for that to be the next release?

Copy link
Contributor Author

@mandar242 mandar242 Apr 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8.0.0 makes sense if that's one we targeting next?
@alinabuzachis @hakbailey

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically we've released a final X-1 minor release at about the same time as the X major release. It gives us one last release of new features prior to the breaking changes that come with the major release and might cause folks to get stuck for a while (ie if they can't update Ansible-core or bump botocore for some reason)

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/4d373ffea21f4079b5648b40e1016b6a

✔️ ansible-galaxy-importer SUCCESS in 3m 54s
✔️ build-ansible-collection SUCCESS in 18m 47s
✔️ ansible-test-splitter SUCCESS in 11m 12s
integration-amazon.aws-1 ERROR Failed to update project ansible/ansible in 3s
✔️ integration-amazon.aws-2 SUCCESS in 17m 36s
integration-amazon.aws-3 ERROR Failed to update project ansible/ansible in 3s
✔️ integration-amazon.aws-4 SUCCESS in 11m 32s
✔️ integration-amazon.aws-5 SUCCESS in 12m 36s
✔️ integration-amazon.aws-6 SUCCESS in 6m 08s
✔️ integration-amazon.aws-7 SUCCESS in 10m 25s
integration-amazon.aws-8 ERROR Failed to update project ansible/zuul-config in 4s
integration-amazon.aws-9 ERROR Failed to update project ansible/ansible in 4s
integration-amazon.aws-10 ERROR Failed to update project ansible/ansible in 5s
integration-amazon.aws-11 ERROR Failed to update project ansible/ansible in 3s
integration-amazon.aws-12 ERROR Failed to update project ansible/ansible in 10s
integration-amazon.aws-13 ERROR Failed to update project ansible/ansible in 3s
integration-amazon.aws-14 ERROR Failed to update project ansible/ansible in 10s
integration-amazon.aws-15 ERROR Failed to update project ansible/ansible in 10s
integration-amazon.aws-16 ERROR Failed to update project ansible/ansible in 2s
integration-amazon.aws-17 ERROR Failed to update project ansible/ansible in 2s
integration-amazon.aws-18 ERROR Failed to update project ansible/ansible in 9s
integration-amazon.aws-19 ERROR Failed to update project ansible/ansible in 2s
Skipped 25 jobs

Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/139973a81386492d8484971055ec938e

✔️ ansible-galaxy-importer SUCCESS in 7m 09s
✔️ build-ansible-collection SUCCESS in 15m 07s
✔️ ansible-test-splitter SUCCESS in 7m 18s
✔️ integration-amazon.aws-1 SUCCESS in 30m 48s
✔️ integration-amazon.aws-2 SUCCESS in 18m 46s
✔️ integration-amazon.aws-3 SUCCESS in 14m 52s
✔️ integration-amazon.aws-4 SUCCESS in 12m 20s
✔️ integration-amazon.aws-5 SUCCESS in 13m 52s
✔️ integration-amazon.aws-6 SUCCESS in 12m 57s
✔️ integration-amazon.aws-7 SUCCESS in 12m 55s
✔️ integration-amazon.aws-8 SUCCESS in 12m 47s
✔️ integration-amazon.aws-9 SUCCESS in 12m 25s
✔️ integration-amazon.aws-10 SUCCESS in 13m 00s
✔️ integration-amazon.aws-11 SUCCESS in 10m 34s
✔️ integration-amazon.aws-12 SUCCESS in 15m 40s
✔️ integration-amazon.aws-13 SUCCESS in 12m 19s
✔️ integration-amazon.aws-14 SUCCESS in 15m 56s
✔️ integration-amazon.aws-15 SUCCESS in 12m 06s
✔️ integration-amazon.aws-16 SUCCESS in 9m 35s
✔️ integration-amazon.aws-17 SUCCESS in 7m 11s
✔️ integration-amazon.aws-18 SUCCESS in 9m 36s
✔️ integration-amazon.aws-19 SUCCESS in 7m 45s
Skipped 25 jobs

@tremble tremble added the backport-7 PR should be backported to the stable-7 branch label Apr 22, 2024
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Apr 22, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/47db198fb94144b8af34daf8124e798a

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 14m 41s
✔️ ansible-test-splitter SUCCESS in 6m 23s
✔️ integration-amazon.aws-1 SUCCESS in 26m 23s
✔️ integration-amazon.aws-2 SUCCESS in 16m 32s
✔️ integration-amazon.aws-3 SUCCESS in 8m 45s
✔️ integration-amazon.aws-4 SUCCESS in 11m 34s
✔️ integration-amazon.aws-5 SUCCESS in 7m 56s
✔️ integration-amazon.aws-6 SUCCESS in 6m 14s
✔️ integration-amazon.aws-7 SUCCESS in 6m 55s
✔️ integration-amazon.aws-8 SUCCESS in 13m 29s
✔️ integration-amazon.aws-9 SUCCESS in 11m 32s
✔️ integration-amazon.aws-10 SUCCESS in 11m 31s
✔️ integration-amazon.aws-11 SUCCESS in 7m 21s
✔️ integration-amazon.aws-12 SUCCESS in 12m 11s
✔️ integration-amazon.aws-13 SUCCESS in 11m 14s
✔️ integration-amazon.aws-14 SUCCESS in 12m 52s
✔️ integration-amazon.aws-15 SUCCESS in 9m 17s
✔️ integration-amazon.aws-16 SUCCESS in 9m 27s
✔️ integration-amazon.aws-17 SUCCESS in 15m 38s
✔️ integration-amazon.aws-18 SUCCESS in 8m 57s
✔️ integration-amazon.aws-19 SUCCESS in 13m 10s
Skipped 25 jobs

Copy link
Contributor

Pull request merge failed: Required status check "ansible/gate" is expected.

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/6e7bc947c99b4a0b9b1ab615cfaf58ba

✔️ ansible-galaxy-importer SUCCESS in 4m 52s
✔️ build-ansible-collection SUCCESS in 15m 28s
✔️ ansible-test-splitter SUCCESS in 5m 47s
✔️ integration-amazon.aws-1 SUCCESS in 26m 15s
✔️ integration-amazon.aws-2 SUCCESS in 16m 27s
✔️ integration-amazon.aws-3 SUCCESS in 17m 08s
✔️ integration-amazon.aws-4 SUCCESS in 11m 30s
✔️ integration-amazon.aws-5 SUCCESS in 11m 52s
✔️ integration-amazon.aws-6 SUCCESS in 6m 18s
integration-amazon.aws-7 FAILURE in 7m 47s
✔️ integration-amazon.aws-8 SUCCESS in 12m 39s
✔️ integration-amazon.aws-9 SUCCESS in 11m 42s
✔️ integration-amazon.aws-10 SUCCESS in 10m 52s
✔️ integration-amazon.aws-11 SUCCESS in 10m 41s
✔️ integration-amazon.aws-12 SUCCESS in 10m 52s
✔️ integration-amazon.aws-13 SUCCESS in 13m 02s
✔️ integration-amazon.aws-14 SUCCESS in 12m 57s
✔️ integration-amazon.aws-15 SUCCESS in 9m 11s
✔️ integration-amazon.aws-16 SUCCESS in 12m 10s
✔️ integration-amazon.aws-17 SUCCESS in 9m 04s
✔️ integration-amazon.aws-18 SUCCESS in 13m 23s
✔️ integration-amazon.aws-19 SUCCESS in 8m 05s
Skipped 25 jobs

@tremble
Copy link
Contributor

tremble commented Apr 22, 2024

recheck

Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/de5651f419f343968eddf15a4704b181

✔️ ansible-galaxy-importer SUCCESS in 4m 55s
✔️ build-ansible-collection SUCCESS in 14m 52s
✔️ ansible-test-splitter SUCCESS in 5m 26s
✔️ integration-amazon.aws-1 SUCCESS in 20m 57s
✔️ integration-amazon.aws-2 SUCCESS in 12m 33s
✔️ integration-amazon.aws-3 SUCCESS in 11m 59s
✔️ integration-amazon.aws-4 SUCCESS in 14m 51s
✔️ integration-amazon.aws-5 SUCCESS in 11m 27s
✔️ integration-amazon.aws-6 SUCCESS in 10m 06s
integration-amazon.aws-7 RETRY_LIMIT in 1m 43s
✔️ integration-amazon.aws-8 SUCCESS in 16m 41s
✔️ integration-amazon.aws-9 SUCCESS in 12m 38s
✔️ integration-amazon.aws-10 SUCCESS in 12m 28s
✔️ integration-amazon.aws-11 SUCCESS in 7m 53s
✔️ integration-amazon.aws-12 SUCCESS in 14m 21s
✔️ integration-amazon.aws-13 SUCCESS in 11m 28s
✔️ integration-amazon.aws-14 SUCCESS in 11m 29s
✔️ integration-amazon.aws-15 SUCCESS in 12m 20s
✔️ integration-amazon.aws-16 SUCCESS in 9m 25s
✔️ integration-amazon.aws-17 SUCCESS in 15m 21s
✔️ integration-amazon.aws-18 SUCCESS in 11m 20s
✔️ integration-amazon.aws-19 SUCCESS in 8m 54s
Skipped 25 jobs

@tremble tremble added mergeit Merge the PR (SoftwareFactory) and removed mergeit Merge the PR (SoftwareFactory) labels Apr 22, 2024
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/71f1534be12d402b84fd9a078acc66d1

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 16m 01s
✔️ ansible-test-splitter SUCCESS in 5m 30s
✔️ integration-amazon.aws-1 SUCCESS in 26m 36s
✔️ integration-amazon.aws-2 SUCCESS in 8m 22s
✔️ integration-amazon.aws-3 SUCCESS in 8m 23s
✔️ integration-amazon.aws-4 SUCCESS in 11m 40s
✔️ integration-amazon.aws-5 SUCCESS in 8m 04s
✔️ integration-amazon.aws-6 SUCCESS in 6m 22s
✔️ integration-amazon.aws-7 SUCCESS in 7m 08s
✔️ integration-amazon.aws-8 SUCCESS in 12m 21s
✔️ integration-amazon.aws-9 SUCCESS in 11m 35s
✔️ integration-amazon.aws-10 SUCCESS in 12m 55s
✔️ integration-amazon.aws-11 SUCCESS in 8m 12s
✔️ integration-amazon.aws-12 SUCCESS in 11m 11s
✔️ integration-amazon.aws-13 SUCCESS in 11m 51s
✔️ integration-amazon.aws-14 SUCCESS in 9m 15s
✔️ integration-amazon.aws-15 SUCCESS in 7m 34s
✔️ integration-amazon.aws-16 SUCCESS in 9m 58s
✔️ integration-amazon.aws-17 SUCCESS in 7m 49s
✔️ integration-amazon.aws-18 SUCCESS in 7m 15s
✔️ integration-amazon.aws-19 SUCCESS in 7m 49s
Skipped 25 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 096b026 into ansible-collections:main Apr 22, 2024
39 of 41 checks passed
Copy link

patchback bot commented Apr 22, 2024

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/096b0267a92980e6936ae29f2a6576211d65211d/pr-2026

Backported as #2061

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 22, 2024
add support for host option in placement.tenancy

SUMMARY

Add host option in tenancy under placement.
Resolves #1990

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION

https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Reviewed-by: Alina Buzachis
Reviewed-by: Helen Bailey <hebailey@redhat.com>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Mark Chappell
(cherry picked from commit 096b026)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 22, 2024
[PR #2026/096b0267 backport][stable-7] add support for host option in placement.tenancy

This is a backport of PR #2026 as merged into main (096b026).
SUMMARY

Add host option in tenancy under placement.
Resolves #1990

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_instance
ADDITIONAL INFORMATION


https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2/client/run_instances.html
The host tenancy is not supported for ImportInstance or for T3 instances that are configured for the unlimited CPU credit option.

Reviewed-by: Mark Chappell
@mandar242 mandar242 deleted the ec2_instance-tenancy-host branch April 26, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 PR should be backported to the stable-7 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

host option in tenancy under placement
4 participants