Inventory aws ec2 unit tests #1072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option to allow multiple duplicated entry for on single instance. Closes: ansible-collections#950
This can happen is a host is found but doesnt match any of the `hostnames` rules.
Break up the `_populate()` method into smaller function. Use @classmethod when possible and reduce the use of `get_option()` to avoid side-effects.
|
@goneri This PR contains |
ansibullbot
added
docs
integration
ansibullbot
added
the
needs_rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1090
SUMMARY
Based on #1026 which should be merged first.
Break up the
_populate()method into smaller functions. Use@classmethodwhen possible and reduce the use ofget_option()to avoid side-effects.