inventory/aws_ec2: deprecate include_extra_api_calls #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goneri
force-pushed
the
inventory-aws_ec2-deprecate-include_extra_api_calls_23915
branch
from
0d07e0b
to
edb22d8
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
inventory
changelogs/fragments/inventory-aws_ec2-include_extra_api_calls-is-deprecated.yaml
Outdated
Show resolved
Hide resolved
The `include_extra_api_calls` option of the inventory plugin is broken and actually crashes the plugin with a `list index out of range` error. It assumes `describe_instance_status` always returns a list with one entry which is not the case if the instance is stopped. In addition, it reads the event from for a `Events` kay that doesn't exist in the answer structure. https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.describe_instance_status The feature is not covered by any tests in our CI and obviously, nobody uses it.
goneri
force-pushed
the
inventory-aws_ec2-deprecate-include_extra_api_calls_23915
branch
from
edb22d8
to
2ef84fd
Compare
alinabuzachis
approved these changes
Oct 3, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
include_extra_api_callsoption of the inventory plugin is brokenand actually crashes the plugin with a
list index out of rangeerror.It assumes
describe_instance_statusalways returns a list with one entrywhich is not the case if the instance is stopped.
In addition, it reads the event from for a
Eventskey that doesn't existin the answer structure.
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/ec2.html#EC2.Client.describe_instance_status
The feature is not covered by any tests in our CI and obviously, nobody uses it.