rds_instance: split up the integration tests #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
integration
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
from
f04c5e9
to
1a95de2
Compare
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
from
1a95de2
to
0b79b23
Compare
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
from
0b79b23
to
6cdf834
Compare
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
2 times, most recently
from
54cf82f
to
d6d4747
Compare
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
2 times, most recently
from
1dbf332
to
3318cc8
Compare
Split the `rds_instance` target in smaller targets.
goneri
force-pushed
the
rds_instance-split-up-the-integration-tests_26343
branch
from
3318cc8
to
b9de2a2
Compare
Comment on lines
+2
to
+3
| collections: | ||
| - community.aws |
There was a problem hiding this comment.
I guess we can remove community.aws.
| - block: | ||
| - name: rds_instance / processor integration tests | ||
| collections: | ||
| - community.aws |
| - block: | ||
| - name: rds_instance / replica integration tests | ||
| collections: | ||
| - community.aws |
| - block: | ||
| - name: rds_instance / restore integration tests | ||
| collections: | ||
| - community.aws |
| - block: | ||
| - name: rds_instance / aurora integration tests | ||
| collections: | ||
| - community.aws |
There was a problem hiding this comment.
I guess we can remove community.aws.
There was a problem hiding this comment.
I will keep this one to limit the side of the refactoring. There is already a lot of moving pieces and I don't want to introduce unrelated changes.
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
recheck |
alinabuzachis
approved these changes
Oct 26, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
rds - add the engine_mode parameter Depends-On: #1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
markuman
pushed a commit
to markuman/amazon.aws
that referenced
this pull request
Nov 14, 2022
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@42688f3
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 8b0444e on top of patchback/backports/stable-5/8b0444ef87c9a65c7ce6b788535dfb6f1744d062/pr-1185 Backporting merged PR #1185 into main
🤖 @patchback |
tremble
pushed a commit
to tremble/amazon.aws
that referenced
this pull request
Jan 9, 2023
rds_instance: split up the integration tests Split the rds_instance target in smaller targets. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Apr 27, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
May 3, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
tremble
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
May 3, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 3, 2023
…#1493) [manual backport stable-5] rds - add the engine_mode parameter (#941) rds - add the engine_mode parameter Depends-On: #1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder goneri@lebouder.net Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ctions#1185) Tagging - Add simple deprecations for purge_tags=False Depends-On: ansible-collections#844 SUMMARY Deprecate the use of purge_tags=False as a default ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_acm.py plugins/modules/route53_health_check.py plugins/modules/route53_zone.py plugins/modules/sqs_queue.py ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
rds_instancetarget in smaller targets.