rds - add the engine_mode parameter #941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
|
recheck |
goneri
force-pushed
the
rds_cluster_engine_mode
branch
from
e9e7be5
to
1cdb9ab
Compare
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
goneri
added a commit
to goneri/amazon.aws
that referenced
this pull request
Oct 21, 2022
Follow up to a recent behaviour change, the Aurora clusters are created with `engine_mode=serverless` by default. When we try to add a new instance with `rds_instance`, we get the following errror: ``` Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters. ``` e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs Address the problem, we will need to add the `engine_mode` parameter to `rds_cluster` through ansible-collections#941 and adjust the test-suite. This commit temporarily disable the aurora integration tests for now.
goneri
added a commit
to goneri/amazon.aws
that referenced
this pull request
Oct 21, 2022
Follow up to a recent behaviour change, the Aurora clusters are created with `engine_mode=serverless` by default. When we try to add a new instance with `rds_instance`, we get the following errror: ``` Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters. ``` e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs Address the problem, we will need to add the `engine_mode` parameter to `rds_cluster` through ansible-collections#941 and adjust the test-suite. This commit temporarily disable the aurora integration tests for now.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 21, 2022
rds_instance: disable aurora integration tests Follow up to a recent behaviour change, the Aurora clusters are created with engine_mode=serverless by default. When we try to add a new instance with rds_instance, we get the following errror: Unable to create DB instance: An error occurred (InvalidParameterValue) when calling the CreateDBInstance operation: Instances cannot be added to Aurora Serverless clusters. e.g: https://ansible.softwarefactory-project.io/zuul/build/f1f7cb085f0c4038b905a216a118c229/logs Address the problem, we will need to add the engine_mode parameter to rds_cluster through #941 and adjust the test-suite. This commit temporarily disable the aurora integration tests for now. Reviewed-by: Alina Buzachis <None>
goneri
reviewed
Oct 21, 2022
plugins/module_utils/rds.py
Outdated
| @@ -185,8 +185,17 @@ def handle_errors(module, exception, method_name, parameters): | |||
| accepted_engines = [ | |||
| 'aurora', 'aurora-mysql', 'aurora-postgresql' | |||
| ] | |||
| accepted_engine_modes = [ | |||
There was a problem hiding this comment.
Isn't this redundant since we already validate the user inputs with argument_spec.
There was a problem hiding this comment.
I can't remember the exact reason behind it now. I guess we can remove these now https://github.com/ansible-collections/amazon.aws/pull/941/files#diff-93f87b21085d00540e096e681c0d162bcc8575fe1c5995fc4b11623df4c6622dR191-R194 as long as we validate the specification.
There was a problem hiding this comment.
With engine, engine_mode and engine_version There is a large range of potential combinations. The API returns a clear message and I would prefer to just rely on this. Also, in the future AWS will probably adjust some of these constraints, if we've got a strict check system we will have to release a new collection version.
goneri
force-pushed
the
rds_cluster_engine_mode
branch
from
1cdb9ab
to
20b3549
Compare
goneri
changed the title
goneri
changed the title
ansibullbot
added
community_review
integration
alinabuzachis
commented
Oct 24, 2022
alinabuzachis
commented
Oct 25, 2022
|
recheck |
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
…ds_cluster Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
goneri
force-pushed
the
rds_cluster_engine_mode
branch
from
2e78c41
to
220e143
Compare
alinabuzachis
commented
Oct 27, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Oct 27, 2022
rds_cluster: split up the test target Depends-On: #941 Split up the test target to avoid the parallel execution. Reviewed-by: Alina Buzachis <None> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
1 task
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Apr 27, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
alinabuzachis
added a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
May 3, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
tremble
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
May 3, 2023
rds - add the engine_mode parameter Depends-On: ansible-collections#1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 3, 2023
…#1493) [manual backport stable-5] rds - add the engine_mode parameter (#941) rds - add the engine_mode parameter Depends-On: #1185 Add a new engine_mode parameter to rds_cluster and also adjust the test-suite follow-up to some recent API changes: With the aurora engine, engine_mode default now on serverless. We cannot adjust the endpoint_port of a serverless cluster. aurora clusters are now encrypted by default (storage_encrypted) The new engine_mode parameter also allows us to re-enable the Aurora test of the rds_instance integration tests. Reviewed-by: Gonéri Le Bouder goneri@lebouder.net Reviewed-by: Alina Buzachis SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New module aws_eks_fargate_profile SUMMARY (this is a copy of ansible-collections#941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
New module aws_eks_fargate_profile SUMMARY (this is a copy of ansible-collections#941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
New module aws_eks_fargate_profile SUMMARY (this is a copy of ansible-collections#941 because i messed up my original branch) New Module - aws_eks_fargate_profile This create a new module to manage fargate profiles in EKS clusters. Requires: ansible-collections#651 ISSUE TYPE New Module Pull Request COMPONENT NAME aws_eks_fargate_profile ADDITIONAL INFORMATION community.aws.aws_eks_fargate_profile - name: create Fargate Profile aws_eks_fargate_profile: name: 'my-profile' state: present cluster_name: 'my-eks-cluster' role_arn: 'arn:aws:iam::999999999999:role/eks-FargatePodExecutionRole' subnets: - subnet-aaaa1111 selectors: - namespace: 'test_nm' labels: label1: test wait: true tags: env: test foo: bar Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: None <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1185
Add a new
engine_modeparameter tords_clusterand also adjust the test-suite follow-up to some recent API changes:engine_modedefault now onserverless.endpoint_portof aserverlesscluster.storage_encrypted)The new
engine_modeparameter also allows us to re-enable the Aurora test of therds_instanceintegration tests.