Move RetryingBotoClientWrapper into module_utils.retries #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/retries
branch
from
3efd3de
to
52a826b
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
added
community_review
feature
|
recheck |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/retries
branch
from
52a826b
to
6748b00
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refacter/retries
branch
from
9d0e571
to
c1babd8
Compare
tremble
force-pushed
the
refacter/retries
branch
from
c1babd8
to
7e9497a
Compare
goneri
approved these changes
Nov 2, 2022
tremble
force-pushed
the
refacter/retries
branch
from
7e9497a
to
9fd7086
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This means we can use it later with non-module plugins
tremble
force-pushed
the
refacter/retries
branch
from
9fd7086
to
b31df60
Compare
alinabuzachis
approved these changes
Nov 2, 2022
|
regate |
|
regate |
|
@goneri ec2_snapshot tests already failing again :/ |
Please, don't disable it. I would like to make it work. |
goneri
added a commit
to goneri/amazon.cloud
that referenced
this pull request
Dec 7, 2022
`RetryingBotoClientWrapper` should now be loaded from `ansible_collections.amazon.aws.plugins.module_utils.retries`. See: ansible-collections/amazon.aws#1230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible-collections/community.aws#1579
SUMMARY
Move RetryingBotoClientWrapper into module_utils.retries
This means we can use it later with non-module plugins
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/modules.py
plugins/module_utils/retries.py
plugins/module_utils/waiters.py
ADDITIONAL INFORMATION