Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refacter lookup plugins #1225

Merged

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Oct 30, 2022

Depends-On: #1248

SUMMARY
  • Refacters the lookup plugins to use common code for common boto3/botocore operations
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/botocore.py
plugins/module_utils/core.py
plugins/module_utils/exceptions.py
plugins/module_utils/modules.py

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Oct 30, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added community_review feature This issue/PR relates to a feature request lookup lookup plugin module_utils module_utils needs_triage new_plugin New plugin plugins plugin (any type) labels Oct 30, 2022
@softwarefactory-project-zuul

This comment was marked as outdated.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as outdated.

1 similar comment
@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble changed the title Refacter module_utils for use with lookup plugins Refacter module_utils.botocore for use with lookup plugins Oct 30, 2022
@tremble tremble marked this pull request as ready for review October 30, 2022 19:02
@tremble tremble changed the title Refacter module_utils.botocore for use with lookup plugins [WIP] Refacter module_utils.botocore for use with lookup plugins Oct 31, 2022
@ansibullbot ansibullbot added the WIP Work in progress label Oct 31, 2022
@softwarefactory-project-zuul

This comment was marked as resolved.

@tremble tremble changed the title [WIP] Refacter module_utils.botocore for use with lookup plugins [WIP] Refacter lookup plugins Nov 1, 2022
@ansibullbot ansibullbot removed the module module label Nov 3, 2022
@softwarefactory-project-zuul
Copy link
Contributor

This change depends on a change that failed to merge.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

@softwarefactory-project-zuul

This comment was marked as resolved.

softwarefactory-project-zuul bot pushed a commit that referenced this pull request Nov 7, 2022
Refacter docs fragments and synchronize modules and plugins

SUMMARY
Move some of our docs fragments about to better reflect what they're for and the fact that we now have our own "amazon.aws..." namespace we can use.

Synchronises the modules and plugins docs fragments (as far as possible)
Updates plugin docs fragments to reflect the previously announced env variable deprecations

Note: the amazon.aws.common.plugins fragment will necessitate some changes to the inventory and lookup plugins before use.  (See also #1225).  However, those changes will then bring them in line with the other modules
ISSUE TYPE

Docs Pull Request

COMPONENT NAME
plugins/docs_fragments
ADDITIONAL INFORMATION

Reviewed-by: Alina Buzachis <None>
changelogs/fragments/1225-refacter-lookup.yml Outdated Show resolved Hide resolved
meta/runtime.yml Show resolved Hide resolved
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 25s
✔️ build-ansible-collection SUCCESS in 5m 01s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 25s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 24s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 11s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 25s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 28s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 24s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 49s
✔️ cloud-tox-py3 SUCCESS in 3m 04s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-amazon.aws-1 SUCCESS in 5m 34s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 23s
✔️ noop SUCCESS in 0s

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Nov 7, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 05s
✔️ build-ansible-collection SUCCESS in 5m 43s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 11m 02s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 58s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 27s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 07s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 40s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 25s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 5m 56s
✔️ cloud-tox-py3 SUCCESS in 3m 20s
✔️ ansible-test-splitter SUCCESS in 2m 54s
✔️ integration-amazon.aws-1 SUCCESS in 6m 21s
⚠️ integration-amazon.aws-2 SKIPPED
⚠️ integration-amazon.aws-3 SKIPPED
⚠️ integration-amazon.aws-4 SKIPPED
⚠️ integration-amazon.aws-5 SKIPPED
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED
✔️ ansible-test-changelog SUCCESS in 2m 19s
✔️ noop SUCCESS in 0s

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 78ea253 into ansible-collections:main Nov 7, 2022
@tremble tremble deleted the refacter/lookup branch February 15, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community_review docs feature This issue/PR relates to a feature request integration tests/integration lookup lookup plugin mergeit Merge the PR (SoftwareFactory) module_utils module_utils needs_maintainer needs_triage new_plugin New plugin plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants