-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refacter lookup plugins #1225
Merged
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
tremble:refacter/lookup
Nov 7, 2022
Merged
Refacter lookup plugins #1225
softwarefactory-project-zuul
merged 3 commits into
ansible-collections:main
from
tremble:refacter/lookup
Nov 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
lookup
lookup plugin
module_utils
module_utils
needs_triage
new_plugin
New plugin
plugins
plugin (any type)
labels
Oct 30, 2022
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
changed the title
Refacter module_utils for use with lookup plugins
Refacter module_utils.botocore for use with lookup plugins
Oct 30, 2022
tremble
changed the title
Refacter module_utils.botocore for use with lookup plugins
[WIP] Refacter module_utils.botocore for use with lookup plugins
Oct 31, 2022
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 1, 2022 12:57
6d25049
to
ff993c7
Compare
tremble
changed the title
[WIP] Refacter module_utils.botocore for use with lookup plugins
[WIP] Refacter lookup plugins
Nov 1, 2022
tremble
force-pushed
the
refacter/lookup
branch
from
November 3, 2022 15:48
ff993c7
to
1b5e519
Compare
This change depends on a change that failed to merge. |
tremble
force-pushed
the
refacter/lookup
branch
from
November 4, 2022 05:20
1b5e519
to
3d635b2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 5, 2022 12:14
c3b5171
to
521b7f3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 5, 2022 14:26
521b7f3
to
f2ca5fa
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 5, 2022 14:53
f2ca5fa
to
dddb9b0
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 5, 2022 15:07
dddb9b0
to
5d467a8
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refacter/lookup
branch
from
November 5, 2022 15:25
5d467a8
to
fe14703
Compare
This comment was marked as resolved.
This comment was marked as resolved.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Refacter docs fragments and synchronize modules and plugins SUMMARY Move some of our docs fragments about to better reflect what they're for and the fact that we now have our own "amazon.aws..." namespace we can use. Synchronises the modules and plugins docs fragments (as far as possible) Updates plugin docs fragments to reflect the previously announced env variable deprecations Note: the amazon.aws.common.plugins fragment will necessitate some changes to the inventory and lookup plugins before use. (See also #1225). However, those changes will then bring them in line with the other modules ISSUE TYPE Docs Pull Request COMPONENT NAME plugins/docs_fragments ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
tremble
force-pushed
the
refacter/lookup
branch
from
November 7, 2022 12:14
fe14703
to
df788a6
Compare
tremble
force-pushed
the
refacter/lookup
branch
from
November 7, 2022 12:22
df788a6
to
799d48b
Compare
tremble
force-pushed
the
refacter/lookup
branch
from
November 7, 2022 12:23
799d48b
to
a556c64
Compare
alinabuzachis
approved these changes
Nov 7, 2022
tremble
force-pushed
the
refacter/lookup
branch
from
November 7, 2022 13:08
a556c64
to
8db9345
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
docs
feature
This issue/PR relates to a feature request
integration
tests/integration
lookup
lookup plugin
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
needs_maintainer
needs_triage
new_plugin
New plugin
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: #1248
SUMMARY
ISSUE TYPE
COMPONENT NAME
plugins/lookup/aws_account_attribute.py
plugins/lookup/aws_secret.py
plugins/lookup/aws_ssm.py
plugins/module_utils/botocore.py
plugins/module_utils/core.py
plugins/module_utils/exceptions.py
plugins/module_utils/modules.py
ADDITIONAL INFORMATION