Add support to _boto3_conn for dicts as well as botocore.config.Config objects #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g objects (So that normal modules can minimise their knowledge of botocore)
ansibullbot
added
community_review
feature
alinabuzachis
approved these changes
Dec 26, 2022
|
recheck |
|
Build failed (gate pipeline). For information on how to proceed, see Warning: |
|
regate |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ions#1307) Rename aws_elasticbeanstalk_app to elasticbeanstalk_app SUMMARY Drop the aws_ prefix from aws_elasticbeanstalk_app in line with the naming guidelines ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_elasticbeanstalk_app.py plugins/modules/elasticbeanstalk_app.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…ions#1307) Rename aws_elasticbeanstalk_app to elasticbeanstalk_app SUMMARY Drop the aws_ prefix from aws_elasticbeanstalk_app in line with the naming guidelines ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_elasticbeanstalk_app.py plugins/modules/elasticbeanstalk_app.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ions#1307) Rename aws_elasticbeanstalk_app to elasticbeanstalk_app SUMMARY Drop the aws_ prefix from aws_elasticbeanstalk_app in line with the naming guidelines ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_elasticbeanstalk_app.py plugins/modules/elasticbeanstalk_app.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Working on #1305 I hit really weird issues passing "config" in as a dictionary (elsewhere we would pass a dict about rather than something as unique as a botocore.config.Config object).
Add support for passing a dict rather than a full blown Config object, this reduces the number of places that need to know about the inner workings of botocore.
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/botocore.py
ADDITIONAL INFORMATION