Refactor S3 connection code #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
ansibullbot
added
community_review
feature
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refactor/s3_connections
branch
2 times, most recently
from
43596ee
to
c7c2b80
Compare
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refactor/s3_connections
branch
from
c7c2b80
to
54071a6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Jan 2, 2023
…g objects (#1307) Add support to _boto3_conn for dicts as well as botocore.config.Config objects SUMMARY Working on #1305 I hit really weird issues passing "config" in as a dictionary (elsewhere we would pass a dict about rather than something as unique as a botocore.config.Config object). Add support for passing a dict rather than a full blown Config object, this reduces the number of places that need to know about the inner workings of botocore. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/botocore.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
tremble
force-pushed
the
refactor/s3_connections
branch
from
54071a6
to
7f4b2de
Compare
tremble
commented
Jan 2, 2023
| except ImportError: | ||
| try: | ||
| from md5 import md5 |
There was a problem hiding this comment.
md5.md5 was a Python 2.x thing, no point trying to import it now we only support Python 3.6+
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
refactor/s3_connections
branch
from
f74bee0
to
71a1240
Compare
alinabuzachis
approved these changes
Jan 3, 2023
tremble
force-pushed
the
refactor/s3_connections
branch
from
71a1240
to
d341daa
Compare
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename AWS config modules SUMMARY Rename various aws_config modules in line with the naming guidelines (remove the aws_ prefix) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_config_aggregation_authorization.py plugins/modules/config_aggregation_authorization.py plugins/modules/aws_config_aggregator.py plugins/modules/config_aggregator.py plugins/modules/aws_config_delivery_channel.py plugins/modules/config_delivery_channel.py plugins/modules/aws_config_recorder.py plugins/modules/config_recorder.py plugins/modules/aws_config_rule.py plugins/modules/config_rule.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Rename AWS config modules SUMMARY Rename various aws_config modules in line with the naming guidelines (remove the aws_ prefix) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_config_aggregation_authorization.py plugins/modules/config_aggregation_authorization.py plugins/modules/aws_config_aggregator.py plugins/modules/config_aggregator.py plugins/modules/aws_config_delivery_channel.py plugins/modules/config_delivery_channel.py plugins/modules/aws_config_recorder.py plugins/modules/config_recorder.py plugins/modules/aws_config_rule.py plugins/modules/config_rule.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 20, 2023
Rename AWS config modules SUMMARY Rename various aws_config modules in line with the naming guidelines (remove the aws_ prefix) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_config_aggregation_authorization.py plugins/modules/config_aggregation_authorization.py plugins/modules/aws_config_aggregator.py plugins/modules/config_aggregator.py plugins/modules/aws_config_delivery_channel.py plugins/modules/config_delivery_channel.py plugins/modules/aws_config_recorder.py plugins/modules/config_recorder.py plugins/modules/aws_config_rule.py plugins/modules/config_rule.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@753bc89
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Rename AWS config modules SUMMARY Rename various aws_config modules in line with the naming guidelines (remove the aws_ prefix) ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/modules/aws_config_aggregation_authorization.py plugins/modules/config_aggregation_authorization.py plugins/modules/aws_config_aggregator.py plugins/modules/config_aggregator.py plugins/modules/aws_config_delivery_channel.py plugins/modules/config_delivery_channel.py plugins/modules/aws_config_recorder.py plugins/modules/config_recorder.py plugins/modules/aws_config_rule.py plugins/modules/config_rule.py ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Builds upon #1303 making the S3 code closer to the rest of our connection code.
ISSUE TYPE
COMPONENT NAME
s3_object
s3_object_info
s3_bucket
ADDITIONAL INFORMATION