route53_info: fix "key error" for health_check operations #1419
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 12s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
|
recheck |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 31s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 09s |
|
@mandar242 Issue was the usual AWS problem, things hadn't quite become available "everywhere". Added a delay and it's now working |
tremble
added
mergeit
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 52s |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
added
backport-5
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1434 🤖 @patchback |
route53_info: fix "key error" for health_check operations SUMMARY Fixes #1396 This pull request Add new return key health_check_observations for health check operations, returned when I(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason) Fixes "Key Error" when getting status or failure_reason of a health check. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Alina Buzachis (cherry picked from commit a27dfd1)
) [PR #1419/a27dfd14 backport][stable-5] route53_info: fix "key error" for health_check operations This is a backport of PR #1419 as merged into main (a27dfd1). SUMMARY Fixes #1396 This pull request Add new return key health_check_observations for health check operations, returned when I(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason) Fixes "Key Error" when getting status or failure_reason of a health check. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_info ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Add ResourceType on ec2 snapshot copy
SUMMARY
Fixes this issue that shows up when tags are specified:
An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_snapshot_copy
ADDITIONAL INFORMATION
# before
botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value
fatal: [localhost]: FAILED! => {
"boto3_version": "1.24.57",
"botocore_version": "1.27.58",
"changed": false,
"error": {
"code": "InvalidParameterValue",
"message": "Tag specification resource type must have a value"
},
....
# after (no error message)
changed: [localhost] => {
"changed": true,
"invocation": {
"module_args": {
.....
Reviewed-by: Mark Chappell <None>
Reviewed-by: Colby Shores <coleshores@gmail.com>
Reviewed-by: None <None>
Add ResourceType on ec2 snapshot copy
SUMMARY
Fixes this issue that shows up when tags are specified:
An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_snapshot_copy
ADDITIONAL INFORMATION
# before
botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value
fatal: [localhost]: FAILED! => {
"boto3_version": "1.24.57",
"botocore_version": "1.27.58",
"changed": false,
"error": {
"code": "InvalidParameterValue",
"message": "Tag specification resource type must have a value"
},
....
# after (no error message)
changed: [localhost] => {
"changed": true,
"invocation": {
"module_args": {
.....
Reviewed-by: Mark Chappell <None>
Reviewed-by: Colby Shores <coleshores@gmail.com>
Reviewed-by: None <None>
Add ResourceType on ec2 snapshot copy
SUMMARY
Fixes this issue that shows up when tags are specified:
An error occurred waiting for the snapshot to become available.: An
error occurred (InvalidParameterValue) when calling the CopySnapshot
operation: Tag specification resource type must have a value
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ec2_snapshot_copy
ADDITIONAL INFORMATION
# before
botocore.exceptions.ClientError: An error occurred (InvalidParameterValue) when calling the CopySnapshot operation: Tag specification resource type must have a value
fatal: [localhost]: FAILED! => {
"boto3_version": "1.24.57",
"botocore_version": "1.27.58",
"changed": false,
"error": {
"code": "InvalidParameterValue",
"message": "Tag specification resource type must have a value"
},
....
# after (no error message)
changed: [localhost] => {
"changed": true,
"invocation": {
"module_args": {
.....
Reviewed-by: Mark Chappell <None>
Reviewed-by: Colby Shores <coleshores@gmail.com>
Reviewed-by: None <None>
SUMMARY
Fixes #1396
This pull request
health_check_observationsfor health check operations, returned whenI(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason)statusorfailure_reasonof a health check.ISSUE TYPE
COMPONENT NAME
route53_info
ADDITIONAL INFORMATION