Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1419/a27dfd14 backport][stable-5] route53_info: fix "key error" for health_check operations #1434

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 17, 2023

This is a backport of PR #1419 as merged into main (a27dfd1).

SUMMARY

Fixes #1396

This pull request

  1. Add new return key health_check_observations for health check operations, returned when I(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason)
  2. Fixes "Key Error" when getting status or failure_reason of a health check.
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

route53_info

ADDITIONAL INFORMATION

route53_info: fix "key error" for health_check operations

SUMMARY

Fixes #1396
This pull request

Add new return key health_check_observations for health check operations, returned when I(query=health_check) and I(health_check_method=status) or I(health_check_method=failure_reason)
Fixes "Key Error" when getting status or failure_reason of a health check.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

route53_info
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Alina Buzachis
(cherry picked from commit a27dfd1)
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 17, 2023
@github-actions
Copy link

github-actions bot commented Mar 17, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/7fc4c6a65fc441f8b90cf84417099393

✔️ ansible-galaxy-importer SUCCESS in 3m 52s
✔️ build-ansible-collection SUCCESS in 12m 25s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 7m 06s
✔️ integration-amazon.aws-2 SUCCESS in 7m 48s
Skipped 42 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a4beb7e into stable-5 Mar 17, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/a27dfd140c04db72b5c0d5a7b2b7fe498899068f/pr-1419 branch March 17, 2023 15:56
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ut parameters (ansible-collections#1435)

cloudfront_distribution: add connection_attempts and connection_timeout parameters

Depends-On: ansible-collections#1569
SUMMARY
Missing connection_attempts & connection_timeout.
Closes ansible-collections#1434.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Brian Scholer <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ut parameters (ansible-collections#1435)

cloudfront_distribution: add connection_attempts and connection_timeout parameters

Depends-On: ansible-collections#1569
SUMMARY
Missing connection_attempts & connection_timeout.
Closes ansible-collections#1434.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Brian Scholer <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ut parameters (ansible-collections#1435)

cloudfront_distribution: add connection_attempts and connection_timeout parameters

Depends-On: ansible-collections#1569
SUMMARY
Missing connection_attempts & connection_timeout.
Closes ansible-collections#1434.
ISSUE TYPE


Docs Pull Request

COMPONENT NAME
cloudfront_distribution

Reviewed-by: Brian Scholer <None>
Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants