rds_instance: fix 'typeError'when tagging gp3 db #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandar242
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
tremble
approved these changes
Mar 24, 2023
tremble
added
mergeit
tremble
reviewed
Mar 24, 2023
|
Merged
1 task
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 17s |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #1444 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
rds_instance: fix 'typeError'when tagging gp3 db SUMMARY This PR fixes bug causing error when managing tags on a gp3 rds database instance, caused by a conditional statement comparing allocated_storage even when it is not provided. currently code returns TypeError: '>=' not supported between instances of 'NoneType' and 'int'. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell (cherry picked from commit f63d191)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
[PR #1437/f63d1919 backport][stable-5] rds_instance: fix 'typeError'when tagging gp3 db This is a backport of PR #1437 as merged into main (f63d191). SUMMARY This PR fixes bug causing error when managing tags on a gp3 rds database instance, caused by a conditional statement comparing allocated_storage even when it is not provided. currently code returns TypeError: '>=' not supported between instances of 'NoneType' and 'int'. ISSUE TYPE Bugfix Pull Request COMPONENT NAME rds_instance ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Changelog Rename ec2_url to endpoint_url SUMMARY In ansible-collections#992 ec2_url was renamed to endpoint_url, with ec2_url remaining as an alias. This fragment is to improve visibility for a cross-collection change. ISSUE TYPE Docs Pull Request COMPONENT NAME changelogs/fragments/ ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes bug causing error when managing tags on a
gp3rds database instance, caused by a conditional statement comparingallocated_storageeven when it is not provided.currently code returns
TypeError: '>=' not supported between instances of 'NoneType' and 'int'.ISSUE TYPE
COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION