Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PR #1437/f63d1919 backport][stable-5] rds_instance: fix 'typeError'when tagging gp3 db #1444

Merged
merged 1 commit into from
Mar 24, 2023
Merged

[PR #1437/f63d1919 backport][stable-5] rds_instance: fix 'typeError'when tagging gp3 db #1444

merged 1 commit into from
Mar 24, 2023

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Mar 24, 2023

This is a backport of PR #1437 as merged into main (f63d191).

SUMMARY

This PR fixes bug causing error when managing tags on a gp3 rds database instance, caused by a conditional statement comparing allocated_storage even when it is not provided.
currently code returns TypeError: '>=' not supported between instances of 'NoneType' and 'int'.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

rds_instance

ADDITIONAL INFORMATION

@mandar242 @patchback
rds_instance: fix 'typeError'when tagging gp3 db (#1437)
5c9b44b 
rds_instance: fix 'typeError'when tagging gp3 db

SUMMARY

This PR fixes bug causing error when managing tags on a gp3 rds database instance, caused by a conditional statement comparing allocated_storage even when it is not provided.
currently code returns TypeError: '>=' not supported between instances of 'NoneType' and 'int'.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

rds_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
(cherry picked from commit f63d191)
@patchback patchback bot mentioned this pull request Mar 24, 2023
Merged
@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 24, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/94cec80443914cd197c1a97c56f89938

✔️ ansible-galaxy-importer SUCCESS in 3m 42s
✔️ build-ansible-collection SUCCESS in 12m 26s
✔️ ansible-test-splitter SUCCESS in 4m 38s
✔️ integration-amazon.aws-1 SUCCESS in 31m 28s
✔️ integration-amazon.aws-2 SUCCESS in 31m 05s
✔️ integration-amazon.aws-3 SUCCESS in 24m 23s
✔️ integration-amazon.aws-4 SUCCESS in 22m 48s
✔️ integration-amazon.aws-5 SUCCESS in 15m 36s
✔️ integration-amazon.aws-6 SUCCESS in 17m 30s
✔️ integration-amazon.aws-7 SUCCESS in 20m 31s
✔️ integration-amazon.aws-8 SUCCESS in 22m 08s
✔️ integration-amazon.aws-9 SUCCESS in 21m 30s
✔️ integration-amazon.aws-10 SUCCESS in 12m 57s
Skipped 34 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 06b2b93 into stable-5 Mar 24, 2023
@softwarefactory-project-zuul softwarefactory-project-zuul bot deleted the patchback/backports/stable-5/f63d1919bc9df032c864c2ec3e085900cdf3f9bf/pr-1437 branch March 24, 2023 18:11
@tremble tremble mentioned this pull request Mar 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tremble @mandar242