s3_object - fix regression related to leading / in object key names #1549
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…ising exceptions as its own
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 55s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 03s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 36s |
softwarefactory-project-zuul
bot
merged commit b53f7d7
into
ansible-collections:main
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #1554 🤖 @patchback |
…1549) s3_object - fix regression related to leading / in object key names SUMMARY fixes #1548 S3 object key names should not include a leading / (https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html). However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning. For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading /. (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases) ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Regression of ansible/ansible#30576 / ansible/ansible#30579 Reviewed-by: Alina Buzachis (cherry picked from commit b53f7d7)
…1549) (#1554) [PR #1549/b53f7d72 backport][stable-6] s3_object - fix regression related to leading / in object key names This is a backport of PR #1549 as merged into main (b53f7d7). SUMMARY fixes #1548 S3 object key names should not include a leading / (https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html). However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning. For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading /. (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases) ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Regression of ansible/ansible#30576 / ansible/ansible#30579 Reviewed-by: Mark Chappell
#1555) s3_object - deprecate leading slash in object keys SUMMARY Deprecate support for removing leading / from object names AWS APIs don't expect it to be there, pruning it may cause pain in future ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Deprecation was split from #1549 Reviewed-by: Alina Buzachis
#1555) s3_object - deprecate leading slash in object keys SUMMARY Deprecate support for removing leading / from object names AWS APIs don't expect it to be there, pruning it may cause pain in future ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Deprecation was split from #1549 Reviewed-by: Alina Buzachis (cherry picked from commit b9d5b48)
#1555) (#1557) [DNM] [PR #1555/b9d5b48b backport][stable-6] s3_object - deprecate leading slash in object keys This is a backport of PR #1555 as merged into main (b9d5b48). SUMMARY Deprecate support for removing leading / from object names AWS APIs don't expect it to be there, pruning it may cause pain in future ISSUE TYPE Feature Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Deprecation was split from #1549 Reviewed-by: Mark Chappell
SUMMARY
fixes #1548
S3 object key names should not include a leading
/(https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-keys.html). However, for historical reasons we've supported them (we just pruned them out) this pruning was dropped in 6.0.0 without warning.For the sake of simplifying things and moving closer to the actual AWS resources, deprecate pruning out the leading
/. (Arbitrarily modifying inputs and resource names tends to lead to strange edge cases)ISSUE TYPE
COMPONENT NAME
s3_object
ADDITIONAL INFORMATION
Regression of ansible/ansible#30576 / ansible/ansible#30579