Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_s3: fix backwards incompatibility for modes put and get with object syntax - fixes #30576 #30579

Merged
merged 1 commit into from
Sep 20, 2017

Conversation

s-hertel
Copy link
Contributor

SUMMARY

previously to use the modes put or get the object had to be specified with a leading /. Since the boto call doesn't take an object like that this was overlooked and removed. Added a check to remove that leading character. Fixes #30576.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/cloud/amazon/aws_s3.py

ANSIBLE VERSION
2.5.0

… with a leading /. Since the boto call doesn't take an object like that this was overlooked and removed. Added a check to remove that leading character.
@ansibot
Copy link
Contributor

ansibot commented Sep 19, 2017

@ansibot ansibot added affects_2.5 This issue/PR affects Ansible v2.5 aws bugfix_pull_request cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 19, 2017
@willthames willthames merged commit b327322 into ansible:devel Sep 20, 2017
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Sep 20, 2017
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 6, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.5 This issue/PR affects Ansible v2.5 aws bug This issue/PR relates to a bug. cloud core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. owner_pr This PR is made by the module's maintainer. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_s3 module error with version id None does not exist
4 participants